-
Notifications
You must be signed in to change notification settings - Fork 1.4k
refactor: v2 release #6903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wmertens
wants to merge
1,837
commits into
main
Choose a base branch
from
build/v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+161,129
−89,075
Open
refactor: v2 release #6903
Changes from 250 commits
Commits
Show all changes
1837 commits
Select commit
Hold shift + click to select a range
d8767fb
fix: serializing reused qrl
Varixo 338ac31
Merge pull request #8131 from QwikDev/v2-fix-serialize-capture-ref
wmertens 06ec88f
fix(types): inside a component the handlers are only QRLs
wmertens dd12f2f
refactor(types): fix exports, correct scopes etc
wmertens a303212
fix(core): qresume event + fix no-resume
wmertens b4b72b8
chore: pnpm api.update
wmertens beab2a0
fix(types): infer types through sync$
wmertens ab5c685
fix: correct @builder.io/qwik override to local
wmertens 89a07ff
Merge pull request #8134 from QwikDev/v2-types
wmertens ee94e34
feat: change behavior of useAsyncComputed
Varixo 6ad11bb
feat: update eslint rules for useAsyncComputed
Varixo 51b37f0
feat: update route loader types
Varixo 0a69921
chore: add changeset
Varixo cecfdc5
chore: pnpm dedupe
Varixo ce512cc
feat: implement cleanup on destroy for async computed
Varixo 4978f20
feat: run cleanup function for async computed before computation
Varixo 6c0c2d0
fix: cleanup store and signals during vnode remove
Varixo 0aed379
feat: extend eslint rule for route loaders
Varixo 07b3729
fix: make sure new promise during the next computation
Varixo 3bbd3d8
chore: add changesets
Varixo 7c77b38
chore: use native node to run ts scripts
Varixo e20e531
fix: allow to modify inline component's children component props
Varixo da59cf0
Merge pull request #8141 from QwikDev/v2-fix-component-prop-set
wmertens 00ca33e
Merge pull request #8138 from QwikDev/v2-run-build-node-native
wmertens f9d925c
refactor: replace cross-spawn with execa
JerryWu1234 022969a
refactor: migrate from CommonJS to ESM by removing CJS builds and upd…
JerryWu1234 cf2d436
chore: update package.json files to use "module" type and remove glob…
JerryWu1234 fe3fbb6
chore: minimum node version for TS support
JerryWu1234 200c81e
Merge pull request #8103 from JerryWu1234/no-cjs
wmertens 94df210
feat: memoize qrl symbols in qwikloader
Varixo 2110331
Merge pull request #8144 from QwikDev/v2-qrls-memoizing
Varixo 959ae79
fix(router dev): restore platform option functionality
wmertens d5760ed
Merge pull request #8126 from QwikDev/v2-async-computed-changes
wmertens 07deb2c
fix: skip apply journal during vnode diff
Varixo 0ad6748
Merge pull request #8143 from QwikDev/v2-skip-journal-during-diff
wmertens fc1dec4
Merge pull request #8145 from QwikDev/v2-fix-dev-platform
wmertens 0c81e2a
feat: introduce blockRender option for useTask$
Varixo 71dc7e4
chore: rename option to deferUpdates
Varixo 4bf17ae
feat: render blocking task by default
Varixo 0782caa
clarify deferUpdates default
wmertens f959dc8
Merge pull request #8107 from QwikDev/v2-blocking-task
wmertens ade0783
Version Packages (beta)
github-actions[bot] 397eaa0
fix Changelog
wmertens 1e7496d
chore: release 2.0.0-beta.14
wmertens 4133638
feat: reactive var props
Varixo 233b086
fix: scheduling already blocked chore
Varixo 86c0ad3
chore: change effect backref to props proxy
Varixo eb68746
fix: handling component props
Varixo 2c111c9
feat: add cleanup for props proxy
Varixo f63d477
fix: cleanup props proxy
Varixo 5746b46
chore: misc changes
Varixo 86e3a98
chore: add changesets
Varixo 1fb75e7
Merge pull request #8156 from QwikDev/v2-reactive-var-props
Varixo dce9976
fix: setting undefined as input value
Varixo 919901f
chore: pnpm dedupe
wmertens 1ff482f
Merge pull request #8157 from QwikDev/v2-fix-input-undefined-value
wmertens 7ddec1b
Merge remote-tracking branch 'origin/main' into v2-merge-main
wmertens de5e864
Merge pull request #8159 from QwikDev/v2-merge-main
wmertens 1fc309c
fix: serialize correctly null or undefined value for signals
Varixo 8af7775
fix: defer reading QScopedStyle until promise resolves for SSR
Varixo 2f4ab02
Merge pull request #8161 from QwikDev/v2-await-jsxoutput-scoped-style
wmertens c008001
fix: handling blocked chores in scheduler
Varixo 2e132fc
Merge pull request #8160 from QwikDev/v2-undefined-default-effects-value
wmertens f026a32
fix: early return if chore is already running
Varixo b91ce76
Merge pull request #8167 from QwikDev/v2-fix-open-code-block
wmertens 23b3dcd
fix: don't trigger document and window events for normal events
Varixo c3221c2
Merge pull request #8170 from QwikDev/v2-qwikloader-document-event-fix
wmertens be5d399
feat: used optimized method for setting changed attribute value
Varixo 0bdbd8f
Merge pull request #8171 from QwikDev/v2-optimize-attr-diff
wmertens 000b3a1
fix(core): move qresume after state init
wmertens f48c13b
fix(serdes): correct serializer handling
wmertens 8ade957
Merge pull request #8175 from QwikDev/v2-fixes
wmertens aaaaf82
perf(serdes): short-circuit uninitialized serializer
wmertens 76fdc14
Merge pull request #8176 from QwikDev/v2-fixes
wmertens 12fee1f
fix: finding projections after client partial rerender
Varixo dd133bc
Merge pull request #8185 from QwikDev/v2-fix-projections-resolving
wmertens d0c137f
fix(dev): click to component with base
wmertens 9627e22
fix: removing children from var props
Varixo a36a963
Merge pull request #8188 from QwikDev/v2-jsx-split-children
wmertens 2a0240a
Merge pull request #8187 from QwikDev/v2-fix-click-to-component
wmertens 8810145
Version Packages (beta)
github-actions[bot] 3c83746
fix(release): revert supabase-auth-helpers-qwik version
wmertens 920f1a4
Merge pull request #8158 from QwikDev/changeset-release/build/v2
wmertens 27d4724
feat: introduce QRLInternal type and update related exports
JerryWu1234 2e08fc7
Merge pull request #8193 from JerryWu1234/build/v2
wmertens 28fcb8a
chore: update dependencies in create-qwik and add deprecation notice …
JerryWu1234 4555a72
Merge pull request #8196 from JerryWu1234/build/v2
wmertens ac63576
Version Packages (beta)
github-actions[bot] 0d4afd9
chore: changelog
wmertens a83ccf3
Merge pull request #8195 from QwikDev/changeset-release/build/v2
wmertens 41e1976
fix(starters): add missing global.css to library starter
JerryWu1234 86e8beb
Merge pull request #8202 from JerryWu1234/miss-global-css
gioboa 265cd06
chore(core): _getQContainerElement only on element
wmertens a4beb4d
chore(core): _run should not wait
wmertens f2b3c7f
chore(serdes): name SerializationBackRef
wmertens 4a300da
refactor(core): ignore className
wmertens cda0703
wip cursors scheduling
wmertens 10f44a6
more logging
wmertens 3da2602
feat(cursors): pass container to vnode functions
Varixo 4faa4ea
chore(types): add event handler type tests
wmertens 0dd7ced
feat(cursors): migrate to journal
Varixo f87a406
feat(cursors): handle changing component props
Varixo d75efa2
feat(cursors): fix some promises cases
Varixo cc050d7
feat(cursors): compute chore impl
Varixo af03abb
feat(cursors): fix apply journal
Varixo 4a89bc9
feat(cursors): fix handling errors
Varixo d377da3
feat(cursors): migrate to single cursor prop
Varixo ed61626
fix(cursors): setting falsy prop
Varixo 3792012
fix(cursors): vnode_diff unit tests
wmertens bda881e
fix(cursors): merge cursors during vnode-diff and fix debug to string
Varixo 6048aae
feat(cursors): initialize render context with waitOn
Varixo 603a396
feat(cursors): propogate dirty flag to blocking cursor
Varixo 61ff799
feat(cursors): fix async computed signals
Varixo baeaa77
feat(cursor): process dirty non-projection vnodes first
Varixo d9231e9
feat(cursors): dont execute qrls for deleted vnodes
Varixo e8a09bd
feat(cursors): fix resource tests
Varixo 82c6cf2
feat(cursors): fix visible tasks
Varixo 3a16bcf
feat(cursors): ssr integration
Varixo c346655
feat(cursors): assign key as : prop value
Varixo 0228cbb
feat(cursors): fix setting innerHTML
Varixo 0b21c01
feat(cursors): fix catching error for runQrl
Varixo c1d0cda
feat(cursors): fix hoisting styles
Varixo 2e86953
feat(cursors): retry on promise while invalidate signal
Varixo bff0856
feat(cursors): remove old scheduler tests
Varixo b92435c
feat(cursors): fix vnode tests
Varixo 7bf055c
feat(cursors): misc changes
Varixo e0dd705
feat(cursors): fix most resource tests
Varixo 7a53f45
feat(cursors): async computed serialization fix
Varixo 05ddd43
feat(cursors): cleanup old code and fix build
Varixo 782c0d8
feat(cursors): fix signals e2e tests
Varixo 5bdd71f
feat(cursors): skip descendant cursors
Varixo 5e15fbf
feat(cursors): fix materialize element vnode key
Varixo 006f207
feat(cursors): change resource e2e tests after behavior change
Varixo 2af6847
feat: better select impl for perf benchmark
Varixo e228454
feat(cursors): add chore-execution unit tests
Varixo 4295175
feat(cursors): fix resource race condition problem
Varixo 9309a80
feat(cursors): fix signal unit test
Varixo 809f246
feat(cursors): better unit chore-execution test output
Varixo b0bbf8a
feat(cursors): small fixes
Varixo a84f4a7
feat(cursors): defer trigger tasks for server while running effects
Varixo a4b6ea3
feat(cursors): fix node diff payload helper methods
Varixo bb14c24
feat(cursors): faster attributes iteration
Varixo 225c224
feat(cursors): use micro and macro tasks for cursors
Varixo 8887ba4
feat(cursors): register qwik loader fix and comparing signal prop
Varixo e37014d
feat(perf): optimizations after deopt analysis
Varixo d3a9ee3
feat(perf): optimize jsx node creation
Varixo 794ee71
feat(perf): dont assign vNode
Varixo d60fa2b
feat(cursors): fix special characters in custom block in vnode data
Varixo 15c6cfb
fix(e2e): less flaky e2e tests
Varixo dd3b419
feat(perf): less inner functions for diff algorithm
Varixo 12f8a03
feat(perf): fast document getter
Varixo a8baea9
feat(perf): factory functions for operations
Varixo 6cca0e5
feat(cursors): fix unnecessary escaping slot names
Varixo 5680f10
feat(cursors): add changesets
Varixo 63cf92e
Merge pull request #8181 from QwikDev/v2-cursors
wmertens b044c5b
fix(cursors): memory allocation fix
Varixo d7b141d
chore: add memory allocation changesets
Varixo 9668413
Merge pull request #8212 from QwikDev/v2-cursors-memory-fix
wmertens 7f1aaa2
fix: correct escaping separator characters in attributes
Varixo d1d9c65
fix: apply journal in correct order for some edge cases
Varixo a3529fc
test: enable skipped test
Varixo 288bb39
Merge pull request #8216 from QwikDev/v2-attr-separator-escaping
wmertens 4486f0d
Merge pull request #8218 from QwikDev/v2-correct-journal-order
wmertens 7c096ff
Version Packages (beta)
github-actions[bot] afa0e57
Update CHANGELOG.md
wmertens c34c237
Merge pull request #8211 from QwikDev/changeset-release/build/v2
wmertens d875827
feat(perf): hoist wrapped signal function
Varixo 898b779
chore: fix macos ci
Varixo f91c57a
feat(optimizer): move event conversion logic to the optimizer
Varixo a0484f4
feat(optimizer): transform event names with transpile_jsx=false
Varixo 2e6663c
fix: correct signal diffing
Varixo 8b282b4
Merge pull request #8219 from QwikDev/v2-wrapped-signal-fn-hoisting
wmertens 0edd98e
Merge pull request #8222 from QwikDev/v2-event-logic-optimzier
wmertens 2dc3638
feat(perf): better prop diffing
Varixo 91321d4
Merge pull request #8221 from QwikDev/v2-diff-signal
wmertens 68e723a
fix: multiple event registering
Varixo 86cd540
Merge pull request #8228 from QwikDev/v2-event-registering
wmertens 9512e75
chore: dep updates
wmertens 5a3d534
chore: pnpm fmt
wmertens c1ea5ec
chore: remove unnecessary catchError
wmertens 8ae2e7c
fix(plugin): correct error message for missing build
wmertens bdbfc0a
fix(core): core build
wmertens 615e261
fix(cursors): show virtual node dirty on vnode_toString
wmertens 8169cb6
fix(core): qwikevents init
wmertens 4b91d01
fix(repl): empty import.meta.env needs parens
wmertens 2a281b2
chore(ci): use more workers
wmertens 183d40b
chore(ci): playwright traces
wmertens 1d1c4d0
Merge pull request #8225 from QwikDev/v2-fixes
wmertens 7606dbe
fix: merging onInput$ and bind handlers
Varixo 9eb9f79
Merge pull request #8240 from QwikDev/v2-fix-bind-handlers
wmertens aab9519
feat: add q:row to props
Varixo ec40926
feat: transform loop event listeners to special format
Varixo c497530
feat: pass iteration item as 3rd argument
Varixo b2513de
feat: hoist qrl inside loop
Varixo c3e9368
feat: handle more params for iteration item
Varixo 7798930
fix: serialize iteration item
Varixo 0628ac5
feat: don't serialize iteration item attr for csr
Varixo a493406
fix: nested components qrl extracting
Varixo 9400046
fix: qrl hoisting for normal function as a component
Varixo 0e2a303
fix: assign container to context early
Varixo a35836b
feat: change q:row to q:p and q:ps
Varixo 6b59884
fix: multiple handlers in loop
Varixo 0ce16bc
test: cleanup fn works as expected in qwik v2 with slotted components
sashkashishka 57289ef
fix: review comment
sashkashishka bd301da
feat: pass iteration item as 3rd argument
Varixo aed54c9
feat: handle more params for iteration item
Varixo b8f0aa1
fix: assign container to context early
Varixo 41bd9da
feat: ElementVNode as subclass of VirtualVNode
Varixo 69c1fcc
feat(perf): convert effectsubscription array to class
Varixo 3d19114
feat(perf): improve signal and vnode creation perf
Varixo 62f40ea
feat(perf): correctly diff event listeners
Varixo 51ea7e7
feat(perf): inline get value for signal
Varixo ad6a0c1
feat(perf): tree shake assert functions in prod
Varixo 871ade0
feat(perf): use isServer for non-test env
Varixo 0dc45a6
feat(perf): const props performance
Varixo 48cb0de
feat(perf): faster create element access
Varixo f104332
feat(perf): use classes for journal operations
Varixo b2f1b08
feat(perf): batch insert or move operations
Varixo 8e86fca
feat(perf): creation mode for vnode-diff, remove untrack for jsxSorted
Varixo 69bae74
feat(perf): move jsxnode condition higher, less memory allocations fo…
Varixo 88fd423
Merge pull request #8238 from sashkashishka/test/add-test-cases-from-…
Varixo 649d3d2
Merge pull request #8223 from QwikDev/v2-each-component
wmertens fa43dfa
Merge pull request #8224 from QwikDev/v2-more-optimizations
wmertens e77b43b
fix: bind:value and onInput$ on the same element part2
Varixo 86ac7e5
fix: incorrectly transforming onInput
Varixo ab40948
fix: _jsxSplit event name convertion
Varixo beefac1
fix: remove transform code duplication
Varixo 9823fc7
feat: new merging logic for events in jsxSplit
Varixo d736225
fix: should move bind value to var props
Varixo d92665e
fix: iteration variable in qrl prop
Varixo 8612421
fix: handle 'static' props in component's var props
Varixo 4c961d1
fix: overriding the same event with different convention
Varixo 98e4376
Merge pull request #8245 from QwikDev/v2-fix-bind-input
Varixo 4f07a08
Merge pull request #8249 from QwikDev/v2-fix-iteration-variable-in-qr…
Varixo 253d190
fix: finding context in unclaimed projections
Varixo 8829960
fix: trigger visible task when component returns null or undefined
Varixo b2c0118
Merge pull request #8258 from QwikDev/v2-context-unclaimed-projections
wmertens a4ae2ef
fix: rendering component with async tasks on server
Varixo 2045f20
Merge pull request #8259 from QwikDev/v2-visible-task-null-undefined
wmertens 5180d29
Merge pull request #8262 from QwikDev/v2-async-tasks-server
wmertens e83a97d
fix: rendering var prop svg attributes with correct namespaces
Varixo 0a8e24d
Merge pull request #8263 from QwikDev/v2-var-prop-svg-attr
wmertens df3ed1a
fix: computed signal memory leak when reusing effect subscriber in loop
Varixo e8ffc2b
fix: rendering arrays without keys
Varixo 631498d
Merge pull request #8267 from QwikDev/v2-arrays-no-key
wmertens 6e73033
fix: component's content rerender with slot edge case
Varixo d319abe
fix: navigate to new page even if transition is failed
Varixo 77c8051
Merge pull request #8254 from QwikDev/v2-fix-computed-memory-leak
wmertens 3d3fed6
Merge pull request #8270 from QwikDev/v2-component-slot-rerender
wmertens 0b871e3
Merge pull request #8271 from QwikDev/v2-fix-0router-navigate
wmertens File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| 1 << 0 | 001 | static listeners | ||
| 1 << 1 | 002 | static subtree | ||
|
|
||
| ## Slots | ||
|
|
||
| ```typescript | ||
| const Parent = component$(() => { | ||
| return ( | ||
| <Child> | ||
| Projection Content | ||
| <span q:slot="secondary">Secondary Content</span> | ||
| <span q:slot="other">Other Content</span> | ||
| </Child> | ||
| }; | ||
| }); | ||
|
|
||
| const Child = component$(() => { | ||
| return ( | ||
| <div> | ||
| <Slot>Default Primary</Slot> | ||
| <Slot name="secondary">Default Secondary</Slot> | ||
| </div> | ||
| ); | ||
| }); | ||
| ``` | ||
|
|
||
| ```html | ||
| <Fragment Parent> | ||
| <Fragment Child> | ||
| <div> | ||
| <Fragment Slot ptr:Child> | ||
| Projected Content | ||
| <template>Default Primary</template> | ||
| </Fragment> | ||
| <Fragment Slot ptr:Child> | ||
| <span q:slot="secondary">Secondary Content</span> | ||
| </Fragment> | ||
| </div> | ||
| </Fragment> | ||
| <template> | ||
| <span q:slot="other">Other Content</span> | ||
| </template> | ||
| </Fragment> | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@builder.io/qwik': patch | ||
| --- | ||
|
|
||
| BREAKING: `useComputed$` no longer accepts Promise results. Instead, use `useSignal` and `useTask$` together to perform async signal updates |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,5 +33,6 @@ | |
| "label": "Serve", | ||
| "onAutoForward": "openPreview" | ||
| } | ||
| } | ||
| }, | ||
| "postCreateCommand": "./.devcontainer/post-create.sh" | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| #!/bin/bash | ||
|
|
||
| git config --global alias.co checkout | ||
| git config --global alias.br branch | ||
| git config --global alias.ci commit | ||
| git config --global alias.st status | ||
| git config --global alias.lg "log --oneline" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # Workaround to cancel workflow runs from forked repositories | ||
| name: Cancel | ||
| on: | ||
| workflow_run: | ||
| workflows: ['ci'] | ||
| types: | ||
| - requested | ||
| jobs: | ||
| cancel: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: styfle/[email protected] | ||
| if: github.event_name == 'pull_request' | ||
| with: | ||
| workflow_id: ${{ github.event.workflow.id }} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| name: Labling Issues | ||
| name: Labeling Issues | ||
|
|
||
| on: | ||
| issues: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Copilot Autofix
AI 6 months ago
To fix the problem, you should add a
permissionsblock to the workflow or to the specific job. The best practice is to set the minimal permissions required for the workflow to function. In this case, the workflow uses thestyfle/cancel-workflow-action, which typically only needsactions: writepermission to cancel workflow runs. Therefore, you should add apermissionsblock withactions: writeat either the workflow root (to apply to all jobs) or at the job level (to apply only to thecanceljob). The change should be made in.github/workflows/cancel.yml, above thejobs:key (for workflow-level) or inside thecancel:job (for job-level). No additional imports or definitions are needed.