feat: Enhance MCP Management TUI with dynamic enable/disable and runtime updates#1831
Merged
feat: Enhance MCP Management TUI with dynamic enable/disable and runtime updates#1831
Conversation
Contributor
📋 Review SummaryThis PR significantly enhances the MCP (Model Context Protocol) management functionality in the TUI by adding dynamic enable/disable capabilities, visual status indicators, and improved server management. The changes are well-structured with new components and hooks to support the enhanced functionality. 🔍 General Feedback
🎯 Specific Feedback🟡 High
🟢 Medium
🔵 Low
✅ Highlights
|
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
- Delete listCommand and refreshCommand from mcpCommand.ts - Update subCommands to only include manageCommand and authCommand - Update documentation to reference MCP management dialog instead of CLI commands - Simplify mcp command description to focus on management dialog and OAuth auth Note: i18n strings for deprecated commands are kept for backward compatibility
…agement dialog - Add tool filtering in AnthropicContentGenerator (skip tools without name/description) - Add isValid and invalidReason fields to MCPToolDisplayInfo type - Show invalid tool warnings in ServerList, ServerDetail, ToolList, and ToolDetail steps - Add translations for all 6 languages (en, zh, de, ja, pt, ru) - Add tests for Anthropic converter and MCP utils
This was referenced Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Enhance MCP (Model Context Protocol) management TUI with runtime dynamic enable/disable for servers, visual status indicators, scope selection configuration, and health monitoring with automatic reconnection capabilities.
Disabling this will modify the corresponding configuration items and allow hot updates to take effect:
{ "mcpServers": {}, "$version": 3, "mcp": { "excluded": [ "playwright" ] } }Tools described as empty will be skipped and prompted.


Dive Deeper
Core Feature Improvements
(disabled)status in the list instead of disappearing entirelyTechnical Implementation Details
Config Layer (
Config):setExcludedMcpServers()method for runtime configuration updatesisMcpServerDisabled()method to check server disabled statusTool Registry Layer (
ToolRegistry):disableMcpServer()method to handle complete server disablement flow (tools, prompts, client disconnection)MCP Client Management Layer (
McpClientManager):disconnectServer()methodTUI Layer:
MCPManagementDialog: Updated to dynamically handle enable and disable operationsServerListStep: Added scope display[user/workspace/extension]and disabled status indicatorServerDetailStep: Added source field and dynamic enable/disable toggle actionDisableScopeSelectStep: New component for selecting disable scope (User/Workspace)Key Behaviors
Reviewer Test Plan
Ctrl+Min the chat interface(disabled)statusTesting Matrix
Linked issues / bugs
#1762
Breaking Changes
None. These changes are backward compatible:
getMcpServers()behavior changed to return all servers (filtering moved to UI layer)isMcpServerDisabled()is a new opt-in method