Merged
Conversation
- Use Promise.race in handleSlashCommand so ESC abort immediately unblocks the submitQuery await chain (fixes /compress blocking input) - Suppress abort error messages in /compress and /summary when cancelled via ESC (cancelSlashCommand already shows "Command cancelled") - Add "(esc to cancel)" hint below pending slash command items - Add i18n translations for the new hint in all 6 locales
Contributor
📋 Review SummaryThis PR addresses an important issue where input remained blocked after cancelling slash commands with ESC. The solution involves using Promise.race for immediate cancellation and suppressing error messages when commands are cancelled. The addition of a PR template is also a good practice improvement. 🔍 General Feedback
🎯 Specific Feedback🟡 High
🟢 Medium
🔵 Low
✅ Highlights
|
ce27430 to
5376ca5
Compare
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
This PR fixes an issue where input remained blocked after cancelling slash commands (like
/compress) with ESC.Before:
After:

Dive Deeper
Issue Fixed
When users cancelled a slash command execution (like
/compressor/summary) using ESC, the input remained blocked because thesubmitQueryawait chain was not properly unblocked.Changes Made
submitQueryawait chain, fixing/compressblocking input/compressor/summarycommands are cancelled via ESC, the abort errors are now suppressed (thecancelSlashCommandalready shows "Command cancelled" message)Reviewer Test Plan
/compressor/summarycommandTesting Matrix
Linked issues / bugs
N/A