Skip to content

Conversation

@QuiiBz
Copy link
Owner

@QuiiBz QuiiBz commented Oct 31, 2025

Closes #131

Add new musl linux builds for x86 and arm64, as we are not statically linking dependencies (because it would bloat the size of the binary): #131 (comment)

The gnu binaries keep the same NPM package name for backward compat sherif-linux-x64 / sherif-linux-arm64, but we have two new variants for musl sherif-linux-x64-musl / sherif-linux-arm64-musl. The GitHub release binaries already end with -gnu so for those, we also simply add new -musl variants and update the GitHub Action to prefer musl if required

@QuiiBz QuiiBz requested a review from Copilot October 31, 2025 23:47
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for musl-based Linux distributions (such as Alpine Linux) by introducing dedicated musl binaries alongside the existing glibc binaries. The implementation includes runtime detection of the libc variant and automatic fallback mechanisms.

  • Adds musl libc detection logic using dynamic linker presence checks
  • Introduces musl-specific binary variants for both x64 and arm64 Linux architectures
  • Updates build and release workflows to produce and publish musl binaries

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.

File Description
npm/app/package.json Adds musl variants as optional dependencies for Linux x64 and arm64
npm/app/index.js Implements musl detection and fallback logic for resolving the correct binary
action/index.ts Adds musl detection to select appropriate GitHub release assets
.github/workflows/release.yml Adds build matrix entries for musl targets and updates package naming logic

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@QuiiBz QuiiBz requested a review from Copilot October 31, 2025 23:56
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@QuiiBz QuiiBz requested a review from Copilot November 1, 2025 00:00
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@QuiiBz QuiiBz merged commit 84e790d into main Nov 1, 2025
10 checks passed
@QuiiBz QuiiBz deleted the feat/musl-build branch November 1, 2025 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing linux musl build causing Sherif to exit silently

1 participant