Merkle airdrop pallet by vrom911 · Pull Request #10 · Quantus-Network/chain

vrom911 · 2025-05-13T11:07:53Z

Implementation of the merkle-airdrop pallet.

It is tested with the merkle-airdrop-cli tool here: https://github.com/Quantus-Network/resonance-api-client/blob/master/examples/async/examples/merkle-airdrop-README.md

I tested different scenarios, it seems to work for me 🤞🏼

pallets/merkle-airdrop/src/lib.rs

dastansam · 2025-05-13T11:23:11Z

pallets/merkle-airdrop/src/lib.rs

+        type RuntimeEvent: From<Event<Self>> + IsType<<Self as frame_system::Config>::RuntimeEvent>;
+
+        /// The currency mechanism.
+        type Currency: Currency<Self::AccountId>;


I think this trait is also deprecated. you should use Mutate and Inspect instead.

pallets/merkle-airdrop/src/lib.rs

runtime/Cargo.toml

pallets/merkle-airdrop/src/lib.rs

dastansam

looks better. main concerns are need for ValidateUnsigned and airdrop already exists checks

pallets/merkle-airdrop/src/lib.rs

dastansam · 2025-05-15T09:12:50Z

pallets/merkle-airdrop/src/tests.rs

@@ -0,0 +1,685 @@
+#![cfg(test)]


as a rule of thumb, we should try to cover all the Error variants in the unit tests. For example, there is no case for AirdropAlreadyExists here

dastansam · 2025-05-15T09:15:05Z

pallets/merkle-airdrop/src/tests.rs

+            merkle_root
+        ));
+
+        // Check initial balance - it might be Some(0) instead of None


maybe what you're looking for is ValueQuery? so that we don't have a case where it could be Some(0)

dastansam · 2025-05-15T09:16:16Z

pallets/merkle-airdrop/src/weights.rs

@@ -0,0 +1,73 @@
+//! weights for pallet_merkle_airdrop


did you generate this or is it manually written? it seems like the latter

Regenerated now, needed fixes in the benchmarking file.
I was not aware that it should be regenerated, I did now.
Based on the tutorial, I used the template, but I don't know if I should leave it in?

illuzen · 2025-05-16T03:31:13Z

I guess this is ready, except for swapping Currency for Fungible?

dastansam · 2025-05-16T04:07:20Z

I guess this is ready, except for swapping Currency for Fungible?

it was already swapped. there are some minor nits and clarifications left

pallets/merkle-airdrop/src/frame-weight-template.hbs

vrom911 · 2025-05-16T13:08:01Z

@illuzen @dastansam , I believe all the comments are applied now. The only thing I am not sure about is the weights template and if it looks legit 🙏🏼

dastansam

lgtm, gj!

chore: Only more logs - no changes chore: Less logs fix: O3 solution fix: Finalization triggered often make difficulty actually difficulty removed unused code, added chain_height to prometheus add difficulty back improved logging, clamped difficulty adjustments, raised max_distance, fixed pct calculation, changed block history to 10 and adjustment period to 1 fix: Spec JSON + QUAN token fixed difficulty reporting to prometheuss changed license to MIT fixed 3 tests cleaned up logs Update external-miner/src/lib.rs Co-authored-by: Copilot <[email protected]> fixed external miner chore: ChainSpec refresh + rename to Quantus chore: Resonance as our testnet name ci: github workflow build, test rename node chore: CLI: Resonance Key -> Quantus Key (#13) Use clippy (#11) * Apply clippy autofix * Fix comparison_chain & doc_lazy_continuation * Fix more warnings Update README.md Update README.md Automated release workflow (#16) * added create release workflow * shell script added * rename * remove caching Merkle airdrop pallet (#10) * Implement initial structure of merkle-airdrop * Improve structure, add all template modules * Implement create_airdrop and fix tests and mock * Implement verify merkle proof, add tests * Use binary_merkle_tree instead of custom function * Implement fund function with tests * implement claim function * Clean up * Use poseidon hasher in verify fn * Try to create merkle root for testing * Add doc for testing * Remove rust-toolchain.toml from git tracking * Remove js script * Make claim recipient be anyone * Revert the signer-receiver change, add test fns * changed hash fn to blake2 * Apply fmt * Fix tests * Add validate_unsigned * Fix link to merkle-airdrop-cli * Address review comments * Remove MaxAirdrops * Add UnsignedClaimPriority in the config * Add delete airdrop functionality * Replace deprecated Currency * Only allow airdrop creators to delete it * Allow creators to claim remain balance when delete * Clean up docs * Remove unsignedValidation, add tests * Remove unnecessary error * Generate weights from the nenchmarking * Use the existing weights template * Use unsigned acc for claims --------- Co-authored-by: illuzen <[email protected]> feat: Tech Collective for Runtime Upgrades (#12) * feat: Membership configuration * feat: Founders in genesis config * feat: First community test * feat: TxExtension - only members can vote for track 0 * feat: Track 0 for members only without token support validation * feat: Proposals for track 0 limited to tech collective members * fix: TxExt rename in node * feat: Genesis presets - tech collective members * chore: Tracks params update * feat: Separate referenda with submit limited * feat: Separate tracks - ready for test fix * feat: Membership removed * feat: First test for TechCollective * feat: Tests for new collective ready * feat: All tests fixed and cleaned * clean: TxExtension * fix: Review comments + formatting * chore: MaxRankOfClass - additional comments Add windows build to release process (#17) windows takes 30 minutes to release... remove special case for 0.0.0 - just use it (#18) Bump poseidon-resonance to 0.4.0 (#20) * Bump poseidon-resonance to 0.4.0 * Update to 0.5.0 chore: Chain-spec JSON - refreshed (#24) feat: vest airdrop rewards (#22) * Replace vesting pallet * Vest airdrops * Update runtime * Resolve comments * Add insufficient balance check move rusty-crystals to github (#26) * move rusty-crystals to github * poseidon-resonance 0.5.0 CLI Updates (#27) * move rusty-crystals to github * CLI updates * moved test data to file * remove redundant comments * poseidon-resonance 0.5.0 * merge from main * Update readme for new CLI commands Replace scheduler in reversible transfers Make benchmarks compile (#29) feat: explicit reverser for reversible accounts (#8) * Add explicit reverser for reversible transfers * Make reverser get reserved funds, update benchmarks * Add more tests updated storage hasher for transfer proofs (#25) * updated storage hasher for transfer proofs * minor cleanup * fixed some tests * tests compile now * Pass AccountId for storage hashing (#30) * tests fixed --------- Co-authored-by: illuzen <[email protected]> Co-authored-by: Dastan <[email protected]> cargo fmt (#31) applied cargo fmt to codebase Update ci.yml (#32) add cargo fmt check don't cache on linux (#33) prevents out of disk space errors Compiling node Make legacy tests work Fix compile errors Run fmt Mostly passing tests

vrom911 and others added 20 commits May 12, 2025 08:51

Implement initial structure of merkle-airdrop

5fab071

Improve structure, add all template modules

8b64f64

Implement create_airdrop and fix tests and mock

e25ae63

Implement verify merkle proof, add tests

f4658cc

Use binary_merkle_tree instead of custom function

d0821eb

Implement fund function with tests

4218151

implement claim function

37cbf6e

Clean up

490b98f

Use poseidon hasher in verify fn

302d9cd

Try to create merkle root for testing

2cbe7e9

Add doc for testing

48a7587

Remove rust-toolchain.toml from git tracking

70cf90d

Remove js script

2a39a34

Make claim recipient be anyone

b0901cf

Revert the signer-receiver change, add test fns

d89ae82

changed hash fn to blake2

c007397

Apply fmt

b38475b

Fix tests

1d8e2f0

Add validate_unsigned

1f83a32

Fix link to merkle-airdrop-cli

41b2b80

vrom911 self-assigned this May 13, 2025

dastansam reviewed May 13, 2025

View reviewed changes

illuzen reviewed May 13, 2025

View reviewed changes

pallets/merkle-airdrop/src/lib.rs Outdated Show resolved Hide resolved

illuzen reviewed May 13, 2025

View reviewed changes

pallets/merkle-airdrop/src/lib.rs Show resolved Hide resolved

vrom911 added 5 commits May 13, 2025 16:54

Address review comments

bce58a4

Remove MaxAirdrops

05b5d7c

Add UnsignedClaimPriority in the config

b4da63d

Add delete airdrop functionality

5932102

Replace deprecated Currency

7c60b2b

vrom911 requested a review from illuzen May 13, 2025 20:36

vrom911 requested a review from dastansam May 13, 2025 20:36

vrom911 added 3 commits May 14, 2025 16:09

Only allow airdrop creators to delete it

63543dc

Allow creators to claim remain balance when delete

7051471

Clean up docs

37bc9c6

dastansam suggested changes May 15, 2025

View reviewed changes

vrom911 added 2 commits May 15, 2025 15:10

Remove unsignedValidation, add tests

b40d561

Remove unnecessary error

862d275

vrom911 commented May 16, 2025

View reviewed changes

pallets/merkle-airdrop/src/frame-weight-template.hbs Outdated Show resolved Hide resolved

Generate weights from the nenchmarking

baf9fec

vrom911 force-pushed the vrom911/merkle-airdrop branch from d0b7b4b to baf9fec Compare May 16, 2025 13:09

Use the existing weights template

7c8e8d4

vrom911 force-pushed the vrom911/merkle-airdrop branch from 80bd410 to 7c8e8d4 Compare May 16, 2025 13:20

Use unsigned acc for claims

988b2f7

vrom911 requested a review from dastansam May 19, 2025 06:39

dastansam approved these changes May 19, 2025

View reviewed changes

czareko self-requested a review May 20, 2025 02:29

czareko approved these changes May 20, 2025

View reviewed changes

illuzen merged commit e4c2fe3 into main May 20, 2025
2 checks passed

vrom911 deleted the vrom911/merkle-airdrop branch May 20, 2025 09:23

n13 mentioned this pull request Mar 5, 2026

Fixing Fork Choice #393

Merged

Conversation

vrom911 commented May 13, 2025

Uh oh!

Uh oh!

dastansam May 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dastansam left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dastansam May 15, 2025

Choose a reason for hiding this comment

Uh oh!

dastansam May 15, 2025

Choose a reason for hiding this comment

Uh oh!

dastansam May 15, 2025

Choose a reason for hiding this comment

Uh oh!

vrom911 May 16, 2025

Choose a reason for hiding this comment

Uh oh!

illuzen commented May 16, 2025

Uh oh!

dastansam commented May 16, 2025

Uh oh!

Uh oh!

vrom911 commented May 16, 2025

Uh oh!

dastansam left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants