Skip to content

Conversation

@acl-cqc
Copy link
Contributor

@acl-cqc acl-cqc commented Jan 23, 2026

Follow-up to #2772, but so far only RemoveDeadFuncsPass and UntuplePass.

Non-breaking, so keeping pre-existing pass configurating methods and storing such config in an Either<PassScope, ....>

@hugrbot
Copy link
Collaborator

hugrbot commented Jan 23, 2026

Hey there and thank you for opening this pull request! 👋

We follow the Conventional Commits convention for PR titles. It looks like your title needs some adjustment.

The title should have a type prefix, followed by a colon. The most important ones are:

  • feat: for new features
  • fix: for bug fixes

If the PR contains a breaking change, use feat!: or fix!: instead and include a "BREAKING CHANGE:" footer in the description of the pull request.

You may also include a (scope) after the type prefix.

Expand this message for the full list of tags.
  • feat: New feature
  • fix: Bug fix
  • docs: Documentation-only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc)
  • refactor: A code change that neither fixes a bug nor adds a feature
  • perf: Performance improvements
  • test: Adding missing or correcting existing tests
  • ci: Changes to our CI configuration files and scripts
  • chore: Other changes that do not alter public APIs or code behaviour
  • revert: Reverts a previous commit

@acl-cqc acl-cqc changed the title WIP: update passes to use PassScope following #2772 WIP: update passes to use PassScope Jan 23, 2026
@codecov
Copy link

codecov bot commented Jan 23, 2026

Codecov Report

❌ Patch coverage is 81.48148% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.33%. Comparing base (11a643e) to head (b3f985b).

Files with missing lines Patch % Lines
hugr-passes/src/untuple.rs 65.67% 22 Missing and 1 partial ⚠️
hugr-passes/src/dead_funcs.rs 95.40% 4 Missing ⚠️
hugr-passes/src/monomorphize.rs 57.14% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           ab/pass-scopes    #2836      +/-   ##
==================================================
- Coverage           83.55%   83.33%   -0.23%     
==================================================
  Files                 263      263              
  Lines               53019    52846     -173     
  Branches            47480    47533      +53     
==================================================
- Hits                44302    44041     -261     
- Misses               6328     6426      +98     
+ Partials             2389     2379      -10     
Flag Coverage Δ
python 88.02% <ø> (+0.81%) ⬆️
rust 82.81% <81.48%> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants