Skip to content

feat: Include private HUGR functions in the local symbol table #2831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cgh-qtnm wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Include private HUGR functions in the local symbol table #2831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hugr-llvm/src/emit.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ impl<'c, 'a, H> EmitModuleContext<'c, 'a, H> {
let name = self.name_func(name, node);
match visibility {
Visibility::Public => self.get_func_impl(name, llvm_func_ty, Some(Linkage::External)),
Visibility::Private => self.get_func_impl(name, llvm_func_ty, Some(Linkage::Private)),
Visibility::Private => self.get_func_impl(name, llvm_func_ty, Some(Linkage::Internal)),
_ => self.get_func_impl(name, llvm_func_ty, None),
}
}
Expand Down
2 changes: 1 addition & 1 deletion ...-llvm/src/emit/ops/snapshots/[email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ expression: mod_str
; ModuleID = 'test_context'
source_filename = "test_context"

define private i8 @_hl.main.1(i8 %0, i8 %1) {
define internal i8 @_hl.main.1(i8 %0, i8 %1) {
alloca_block:
br label %entry_block

Expand Down
2 changes: 1 addition & 1 deletion ...it/ops/snapshots/hugr_llvm__emit__ops__cfg__test__diverse_outputs@[email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ expression: mod_str
; ModuleID = 'test_context'
source_filename = "test_context"

define private i8 @_hl.main.1(i8 %0, i8 %1) {
define internal i8 @_hl.main.1(i8 %0, i8 %1) {
alloca_block:
%"0" = alloca i8, align 1
%"2_0" = alloca i8, align 1
Expand Down
2 changes: 1 addition & 1 deletion hugr-llvm/src/emit/ops/snapshots/[email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ expression: mod_str
; ModuleID = 'test_context'
source_filename = "test_context"

define private i1 @_hl.main.1(i2 %0, i1 %1) {
define internal i1 @_hl.main.1(i2 %0, i1 %1) {
alloca_block:
br label %entry_block

Expand Down
2 changes: 1 addition & 1 deletion ...vm/src/emit/ops/snapshots/hugr_llvm__emit__ops__cfg__test__nested@[email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ expression: mod_str
; ModuleID = 'test_context'
source_filename = "test_context"

define private i1 @_hl.main.1(i2 %0, i1 %1) {
define internal i1 @_hl.main.1(i2 %0, i1 %1) {
alloca_block:
%"0" = alloca i1, align 1
%"5_0" = alloca {}, align 8
Expand Down
2 changes: 1 addition & 1 deletion ...llvm/src/emit/snapshots/hugr_llvm__emit__test__test_fns__diverse_cfg_children@llvm14.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ expression: mod_str
; ModuleID = 'test_context'
source_filename = "test_context"

define private i1 @_hl.main.1() {
define internal i1 @_hl.main.1() {
alloca_block:
br label %entry_block

Expand Down
2 changes: 1 addition & 1 deletion ...t/snapshots/hugr_llvm__emit__test__test_fns__diverse_cfg_children@[email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ expression: mod_str
; ModuleID = 'test_context'
source_filename = "test_context"

define private i1 @_hl.main.1() {
define internal i1 @_hl.main.1() {
alloca_block:
%"0" = alloca i1, align 1
%"4_0" = alloca i1, align 1
Expand Down
4 changes: 2 additions & 2 deletions ...m/src/emit/snapshots/hugr_llvm__emit__test__test_fns__diverse_module_children@llvm14.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,15 @@ expression: mod_str
; ModuleID = 'test_context'
source_filename = "test_context"

define private void @_hl.f1.1() {
define internal void @_hl.f1.1() {
alloca_block:
br label %entry_block

entry_block: ; preds = %alloca_block
ret void
}

define private void @_hl.f2.4() {
define internal void @_hl.f2.4() {
alloca_block:
br label %entry_block

Expand Down
4 changes: 2 additions & 2 deletions ...napshots/hugr_llvm__emit__test__test_fns__diverse_module_children@[email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,15 @@ expression: mod_str
; ModuleID = 'test_context'
source_filename = "test_context"

define private void @_hl.f1.1() {
define internal void @_hl.f1.1() {
alloca_block:
br label %entry_block

entry_block: ; preds = %alloca_block
ret void
}

define private void @_hl.f2.4() {
define internal void @_hl.f2.4() {
alloca_block:
br label %entry_block

Expand Down
2 changes: 1 addition & 1 deletion ...lvm/src/emit/snapshots/hugr_llvm__emit__test__test_fns__emit_hugr_conditional@llvm14.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ expression: mod_str
; ModuleID = 'test_context'
source_filename = "test_context"

define private { { i2, i2, i1 }, {} } @_hl.main.1({ i2, i2, i1 } %0, {} %1) {
define internal { { i2, i2, i1 }, {} } @_hl.main.1({ i2, i2, i1 } %0, {} %1) {
alloca_block:
br label %entry_block

Expand Down
2 changes: 1 addition & 1 deletion .../snapshots/hugr_llvm__emit__test__test_fns__emit_hugr_conditional@[email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ expression: mod_str
; ModuleID = 'test_context'
source_filename = "test_context"

define private { { i2, i2, i1 }, {} } @_hl.main.1({ i2, i2, i1 } %0, {} %1) {
define internal { { i2, i2, i1 }, {} } @_hl.main.1({ i2, i2, i1 } %0, {} %1) {
alloca_block:
%"0" = alloca { i2, i2, i1 }, align 8
%"1" = alloca {}, align 8
Expand Down
2 changes: 1 addition & 1 deletion ...-llvm/src/emit/snapshots/[email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ expression: mod_str
; ModuleID = 'test_context'
source_filename = "test_context"

define private i16 @_hl.main.1() {
define internal i16 @_hl.main.1() {
alloca_block:
br label %entry_block

Expand Down
2 changes: 1 addition & 1 deletion ...it/snapshots/hugr_llvm__emit__test__test_fns__emit_hugr_custom_op@[email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ expression: mod_str
; ModuleID = 'test_context'
source_filename = "test_context"

define private i16 @_hl.main.1() {
define internal i16 @_hl.main.1() {
alloca_block:
%"0" = alloca i16, align 2
%"7_0" = alloca i16, align 2
Expand Down
2 changes: 1 addition & 1 deletion hugr-llvm/src/emit/snapshots/[email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ expression: mod_str
; ModuleID = 'test_context'
source_filename = "test_context"

define private {} @_hl.main.1({} %0) {
define internal {} @_hl.main.1({} %0) {
alloca_block:
br label %entry_block

Expand Down
2 changes: 1 addition & 1 deletion ...src/emit/snapshots/hugr_llvm__emit__test__test_fns__emit_hugr_dfg@[email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ expression: mod_str
; ModuleID = 'test_context'
source_filename = "test_context"

define private {} @_hl.main.1({} %0) {
define internal {} @_hl.main.1({} %0) {
alloca_block:
%"0" = alloca {}, align 8
%"2_0" = alloca {}, align 8
Expand Down
2 changes: 1 addition & 1 deletion ...m/src/emit/snapshots/hugr_llvm__emit__test__test_fns__emit_hugr_load_constant@llvm14.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ expression: mod_str
; ModuleID = 'test_context'
source_filename = "test_context"

define private { i2, i16 } @_hl.main.1() {
define internal { i2, i16 } @_hl.main.1() {
alloca_block:
br label %entry_block

Expand Down
2 changes: 1 addition & 1 deletion ...napshots/hugr_llvm__emit__test__test_fns__emit_hugr_load_constant@[email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ expression: mod_str
; ModuleID = 'test_context'
source_filename = "test_context"

define private { i2, i16 } @_hl.main.1() {
define internal { i2, i16 } @_hl.main.1() {
alloca_block:
%"0" = alloca { i2, i16 }, align 8
%"5_0" = alloca { i2, i16 }, align 8
Expand Down
2 changes: 1 addition & 1 deletion hugr-llvm/src/emit/snapshots/[email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ expression: mod_str
; ModuleID = 'test_context'
source_filename = "test_context"

define private i2 @_hl.main.1() {
define internal i2 @_hl.main.1() {
alloca_block:
br label %entry_block

Expand Down
2 changes: 1 addition & 1 deletion ...src/emit/snapshots/hugr_llvm__emit__test__test_fns__emit_hugr_tag@[email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ expression: mod_str
; ModuleID = 'test_context'
source_filename = "test_context"

define private i2 @_hl.main.1() {
define internal i2 @_hl.main.1() {
alloca_block:
%"0" = alloca i2, align 1
%"4_0" = alloca i2, align 1
Expand Down
2 changes: 1 addition & 1 deletion hugr-llvm/src/emit/snapshots/[email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ expression: mod_str
; ModuleID = 'test_context'
source_filename = "test_context"

define private void ()* @_hl.main.2() {
define internal void ()* @_hl.main.2() {
alloca_block:
br label %entry_block

Expand Down
2 changes: 1 addition & 1 deletion ...src/emit/snapshots/hugr_llvm__emit__test__test_fns__load_function@[email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ expression: mod_str
; ModuleID = 'test_context'
source_filename = "test_context"

define private void ()* @_hl.main.2() {
define internal void ()* @_hl.main.2() {
alloca_block:
%"0" = alloca void ()*, align 8
%"5_0" = alloca void ()*, align 8
Expand Down
2 changes: 1 addition & 1 deletion hugr-llvm/src/emit/snapshots/[email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ expression: mod_str
; ModuleID = 'test_context'
source_filename = "test_context"

define private i64 @_hl.main.1() {
define internal i64 @_hl.main.1() {
alloca_block:
br label %entry_block

Expand Down
2 changes: 1 addition & 1 deletion ...lvm/src/emit/snapshots/hugr_llvm__emit__test__test_fns__tail_loop@[email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ expression: mod_str
; ModuleID = 'test_context'
source_filename = "test_context"

define private i64 @_hl.main.1() {
define internal i64 @_hl.main.1() {
alloca_block:
%"0" = alloca i64, align 8
%"7_0" = alloca i64, align 8
Expand Down
2 changes: 1 addition & 1 deletion hugr-llvm/src/emit/snapshots/[email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ expression: mod_str
; ModuleID = 'test_context'
source_filename = "test_context"

define private {} @_hl.main.1(i64 %0) {
define internal {} @_hl.main.1(i64 %0) {
alloca_block:
br label %entry_block

Expand Down
2 changes: 1 addition & 1 deletion .../emit/snapshots/hugr_llvm__emit__test__test_fns__tail_loop_simple@[email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ expression: mod_str
; ModuleID = 'test_context'
source_filename = "test_context"

define private {} @_hl.main.1(i64 %0) {
define internal {} @_hl.main.1(i64 %0) {
alloca_block:
%"0" = alloca {}, align 8
%"2_0" = alloca i64, align 8
Expand Down
2 changes: 1 addition & 1 deletion ...ctions/snapshots/hugr_llvm__extension__collections__array__test__emit_all_ops@llvm14.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ source_filename = "test_context"
@4 = private unnamed_addr constant [37 x i8] c"Expected variant 1 but got variant 0\00", align 1
@prelude.panic_template.4 = private unnamed_addr constant [34 x i8] c"Program panicked (signal %i): %s\0A\00", align 1

define private void @_hl.main.1() {
define internal void @_hl.main.1() {
alloca_block:
br label %entry_block

Expand Down
2 changes: 1 addition & 1 deletion ...hots/hugr_llvm__extension__collections__array__test__emit_all_ops@[email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ source_filename = "test_context"
@4 = private unnamed_addr constant [37 x i8] c"Expected variant 1 but got variant 0\00", align 1
@prelude.panic_template.4 = private unnamed_addr constant [34 x i8] c"Program panicked (signal %i): %s\0A\00", align 1

define private void @_hl.main.1() {
define internal void @_hl.main.1() {
alloca_block:
%"12_0" = alloca i64, align 8
%"10_0" = alloca i64, align 8
Expand Down
2 changes: 1 addition & 1 deletion ...ns/snapshots/hugr_llvm__extension__collections__array__test__emit_array_value@llvm14.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ expression: mod_str
; ModuleID = 'test_context'
source_filename = "test_context"

define private { i64*, i64 } @_hl.main.1() {
define internal { i64*, i64 } @_hl.main.1() {
alloca_block:
br label %entry_block

Expand Down
2 changes: 1 addition & 1 deletion .../hugr_llvm__extension__collections__array__test__emit_array_value@[email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ expression: mod_str
; ModuleID = 'test_context'
source_filename = "test_context"

define private { i64*, i64 } @_hl.main.1() {
define internal { i64*, i64 } @_hl.main.1() {
alloca_block:
%"0" = alloca { i64*, i64 }, align 8
%"5_0" = alloca { i64*, i64 }, align 8
Expand Down
2 changes: 1 addition & 1 deletion ...lections/snapshots/hugr_llvm__extension__collections__array__test__emit_clone@llvm14.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ expression: mod_str
; ModuleID = 'test_context'
source_filename = "test_context"

define private void @_hl.main.1() {
define internal void @_hl.main.1() {
alloca_block:
br label %entry_block

Expand Down
2 changes: 1 addition & 1 deletion ...pshots/hugr_llvm__extension__collections__array__test__emit_clone@[email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ expression: mod_str
; ModuleID = 'test_context'
source_filename = "test_context"

define private void @_hl.main.1() {
define internal void @_hl.main.1() {
alloca_block:
%"7_0" = alloca i64, align 8
%"5_0" = alloca i64, align 8
Expand Down
2 changes: 1 addition & 1 deletion ...ollections/snapshots/hugr_llvm__extension__collections__array__test__emit_get@llvm14.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ expression: mod_str
; ModuleID = 'test_context'
source_filename = "test_context"

define private void @_hl.main.1() {
define internal void @_hl.main.1() {
alloca_block:
br label %entry_block

Expand Down
2 changes: 1 addition & 1 deletion ...napshots/hugr_llvm__extension__collections__array__test__emit_get@[email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ expression: mod_str
; ModuleID = 'test_context'
source_filename = "test_context"

define private void @_hl.main.1() {
define internal void @_hl.main.1() {
alloca_block:
%"7_0" = alloca i64, align 8
%"5_0" = alloca i64, align 8
Expand Down
2 changes: 1 addition & 1 deletion ...snapshots/hugr_llvm__extension__collections__borrow_array__test__emit_all_ops@llvm14.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ source_filename = "test_context"
@5 = private unnamed_addr constant [37 x i8] c"Expected variant 1 but got variant 0\00", align 1
@prelude.panic_template.5 = private unnamed_addr constant [34 x i8] c"Program panicked (signal %i): %s\0A\00", align 1

define private void @_hl.main.1() {
define internal void @_hl.main.1() {
alloca_block:
br label %entry_block

Expand Down
2 changes: 1 addition & 1 deletion ...gr_llvm__extension__collections__borrow_array__test__emit_all_ops@[email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ source_filename = "test_context"
@5 = private unnamed_addr constant [37 x i8] c"Expected variant 1 but got variant 0\00", align 1
@prelude.panic_template.5 = private unnamed_addr constant [34 x i8] c"Program panicked (signal %i): %s\0A\00", align 1

define private void @_hl.main.1() {
define internal void @_hl.main.1() {
alloca_block:
%"12_0" = alloca i64, align 8
%"10_0" = alloca i64, align 8
Expand Down
2 changes: 1 addition & 1 deletion ...shots/hugr_llvm__extension__collections__borrow_array__test__emit_array_value@llvm14.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ expression: mod_str
; ModuleID = 'test_context'
source_filename = "test_context"

define private { i64*, i64*, i64 } @_hl.main.1() {
define internal { i64*, i64*, i64 } @_hl.main.1() {
alloca_block:
br label %entry_block

Expand Down
2 changes: 1 addition & 1 deletion ...lvm__extension__collections__borrow_array__test__emit_array_value@[email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ expression: mod_str
; ModuleID = 'test_context'
source_filename = "test_context"

define private { i64*, i64*, i64 } @_hl.main.1() {
define internal { i64*, i64*, i64 } @_hl.main.1() {
alloca_block:
%"0" = alloca { i64*, i64*, i64 }, align 8
%"5_0" = alloca { i64*, i64*, i64 }, align 8
Expand Down
2 changes: 1 addition & 1 deletion ...s/snapshots/hugr_llvm__extension__collections__borrow_array__test__emit_clone@llvm14.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ source_filename = "test_context"
@0 = private unnamed_addr constant [39 x i8] c"Some array elements have been borrowed\00", align 1
@prelude.panic_template = private unnamed_addr constant [34 x i8] c"Program panicked (signal %i): %s\0A\00", align 1

define private void @_hl.main.1() {
define internal void @_hl.main.1() {
alloca_block:
br label %entry_block

Expand Down
2 changes: 1 addition & 1 deletion ...hugr_llvm__extension__collections__borrow_array__test__emit_clone@[email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ source_filename = "test_context"
@0 = private unnamed_addr constant [39 x i8] c"Some array elements have been borrowed\00", align 1
@prelude.panic_template = private unnamed_addr constant [34 x i8] c"Program panicked (signal %i): %s\0A\00", align 1

define private void @_hl.main.1() {
define internal void @_hl.main.1() {
alloca_block:
%"7_0" = alloca i64, align 8
%"5_0" = alloca i64, align 8
Expand Down
2 changes: 1 addition & 1 deletion ...ons/snapshots/hugr_llvm__extension__collections__borrow_array__test__emit_get@llvm14.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ source_filename = "test_context"
@0 = private unnamed_addr constant [34 x i8] c"Array element is already borrowed\00", align 1
@prelude.panic_template = private unnamed_addr constant [34 x i8] c"Program panicked (signal %i): %s\0A\00", align 1

define private void @_hl.main.1() {
define internal void @_hl.main.1() {
alloca_block:
br label %entry_block

Expand Down
2 changes: 1 addition & 1 deletion ...s/hugr_llvm__extension__collections__borrow_array__test__emit_get@[email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ source_filename = "test_context"
@0 = private unnamed_addr constant [34 x i8] c"Array element is already borrowed\00", align 1
@prelude.panic_template = private unnamed_addr constant [34 x i8] c"Program panicked (signal %i): %s\0A\00", align 1

define private void @_hl.main.1() {
define internal void @_hl.main.1() {
alloca_block:
%"7_0" = alloca i64, align 8
%"5_0" = alloca i64, align 8
Expand Down
2 changes: 1 addition & 1 deletion ...on/collections/snapshots/[email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ expression: mod_str
; ModuleID = 'test_context'
source_filename = "test_context"

define private i8* @_hl.main.1() {
define internal i8* @_hl.main.1() {
alloca_block:
br label %entry_block

Expand Down
Loading
Loading