Skip to content

Conversation

@cgh-qtnm
Copy link

This PR changes the LLVM linkage type for functions with HUGR Visibility::Private from Linkage::Private to Linkage::Internal. The only difference between the two types is that Internal functions show up in the local symbol table of the resulting binary, while Private functions do not.

This change makes it easier to debug and profile compiled HUGR programs, by enabling the inclusion of HUGR functions in call stacks generated by a debugger or profiler. I see several other linkage-related PRs around but none of them seem focused on this exact issue - let me know if this is incorrect.

@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.64%. Comparing base (15b27cd) to head (f71be1e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2831   +/-   ##
=======================================
  Coverage   83.64%   83.64%           
=======================================
  Files         261      261           
  Lines       52837    52837           
  Branches    47372    47372           
=======================================
  Hits        44195    44195           
  Misses       6253     6253           
  Partials     2389     2389           
Flag Coverage Δ
python 87.97% <ø> (ø)
rust 83.14% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cgh-qtnm cgh-qtnm marked this pull request as ready for review January 21, 2026 15:51
@cgh-qtnm cgh-qtnm requested a review from a team as a code owner January 21, 2026 15:51
@cgh-qtnm cgh-qtnm requested a review from doug-q January 21, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants