Skip to content

feat: Allow creating DFG builders from existing hugrs #2562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aborgna-q merged 1 commit into from
Sep 18, 2025
Merged

feat: Allow creating DFG builders from existing hugrs #2562

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions hugr-core/src/builder/dataflow.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ use std::marker::PhantomData;

use crate::hugr::internal::HugrMutInternals;
use crate::hugr::{HugrView, ValidationError};
use crate::ops::handle::NodeHandle;
use crate::ops::{self, DataflowParent, FuncDefn, Input, OpParent, Output};
use crate::types::{PolyFuncType, Signature, Type};
use crate::{Direction, Hugr, IncomingPort, Node, OutgoingPort, Visibility, Wire, hugr::HugrMut};
Expand All @@ -26,7 +27,7 @@ impl<T: AsMut<Hugr> + AsRef<Hugr>> DFGBuilder<T> {
///
/// Sets up the input and output nodes of the region. If `parent` already has
/// input and output nodes, use [`DFGBuilder::create`] instead.
pub(super) fn create_with_io(
pub fn create_with_io(
mut base: T,
parent: Node,
signature: Signature,
Expand Down Expand Up @@ -58,7 +59,7 @@ impl<T: AsMut<Hugr> + AsRef<Hugr>> DFGBuilder<T> {
///
/// If `parent` doesn't have input and output nodes, use
/// [`DFGBuilder::create_with_io`] instead.
pub(super) fn create(base: T, parent: Node) -> Result<Self, BuildError> {
pub fn create(base: T, parent: Node) -> Result<Self, BuildError> {
let sig = base
.as_ref()
.get_optype(parent)
Expand Down Expand Up @@ -137,10 +138,19 @@ impl<T: AsMut<Hugr> + AsRef<Hugr>> Dataflow for DFGBuilder<T> {
#[derive(Debug, Clone, PartialEq)]
pub struct DFGWrapper<B, T>(DFGBuilder<B>, PhantomData<T>);

impl<B, T> DFGWrapper<B, T> {
pub(super) fn from_dfg_builder(db: DFGBuilder<B>) -> Self {
impl<B, T: NodeHandle> DFGWrapper<B, T> {
/// Wrap a [`DFGBuilder`] into a [`DFGWrapper`], with the given handle type.
///
/// The caller must ensure that the DFGBuilder's parent node has the correct
/// handle type given by `T::TAG`.
pub fn from_dfg_builder(db: DFGBuilder<B>) -> Self {
Self(db, PhantomData)
}

/// Unwrap the [`DFGWrapper`] into a [`DFGBuilder`].
pub fn into_dfg_builder(self) -> DFGBuilder<B> {
self.0
}
}

/// Builder for a [`ops::FuncDefn`] node
Expand Down
Loading