Skip to content

feat: Include copy_discard_array in DelegatingLinearizer::default #2479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acl-cqc merged 1 commit into from
Jul 28, 2025
Merged

feat: Include copy_discard_array in DelegatingLinearizer::default #2479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions hugr-passes/src/linearize_array.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ use hugr_core::{
std_extensions::collections::{
array::{
ARRAY_REPEAT_OP_ID, ARRAY_SCAN_OP_ID, Array, ArrayKind, ArrayOpDef, ArrayRepeatDef,
ArrayScanDef, ArrayValue, array_type_def, array_type_parametric,
ArrayScanDef, ArrayValue, array_type_parametric,
},
value_array::{self, VArrayFromArrayDef, VArrayToArrayDef, VArrayValue, ValueArray},
},
Expand All @@ -21,9 +21,7 @@ use strum::IntoEnumIterator;

use crate::{
ComposablePass, ReplaceTypes,
replace_types::{
DelegatingLinearizer, NodeTemplate, ReplaceTypesError, handlers::copy_discard_array,
},
replace_types::{DelegatingLinearizer, NodeTemplate, ReplaceTypesError},
};

/// A HUGR -> HUGR pass that turns 'value_array`s into regular linear `array`s.
Expand Down Expand Up @@ -114,8 +112,6 @@ impl Default for LinearizeArrayPass {
))
},
);
pass.linearizer()
.register_callback(array_type_def(), copy_discard_array);
Self(pass)
}
}
Expand Down
5 changes: 4 additions & 1 deletion hugr-passes/src/replace_types/linearize.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,14 @@ use hugr_core::builder::{
HugrBuilder, inout_sig,
};
use hugr_core::extension::{SignatureError, TypeDef};
use hugr_core::std_extensions::collections::array::array_type_def;
use hugr_core::std_extensions::collections::value_array::value_array_type_def;
use hugr_core::types::{CustomType, Signature, Type, TypeArg, TypeEnum, TypeRow};
use hugr_core::{HugrView, IncomingPort, Node, Wire, hugr::hugrmut::HugrMut, ops::Tag};
use itertools::Itertools;

use super::{NodeTemplate, ParametricType, handlers::linearize_value_array};
use super::handlers::{copy_discard_array, linearize_value_array};
use super::{NodeTemplate, ParametricType};

/// Trait for things that know how to wire up linear outports to other than one
/// target. Used to restore Hugr validity when a [`ReplaceTypes`](super::ReplaceTypes)
Expand Down Expand Up @@ -124,6 +126,7 @@ impl Default for DelegatingLinearizer {
fn default() -> Self {
let mut res = Self::new_empty();
res.register_callback(value_array_type_def(), linearize_value_array);
res.register_callback(array_type_def(), copy_discard_array);
res
}
}
Expand Down
Loading