Skip to content

refactor!: remove deprecated runtime extension errors #2369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ss2165 merged 2 commits into from
Jun 25, 2025
Merged

refactor!: remove deprecated runtime extension errors #2369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a5bf2c
refactor!: remove deprecated runtime extension errors
ss2165 Jun 24, 2025
ee63893
Merge branch 'main' into ss/push-tvwytuzrxwvl
ss2165 Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions hugr-core/src/envelope/package_json.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ use std::io;
use super::{ExtensionBreakingError, WithGenerator, check_breaking_extensions};
use crate::extension::ExtensionRegistry;
use crate::extension::resolution::ExtensionResolutionError;
use crate::hugr::ExtensionError;
use crate::package::Package;
use crate::{Extension, Hugr};

Expand Down Expand Up @@ -73,8 +72,6 @@ pub enum PackageEncodingError {
ExtensionResolution(WithGenerator<ExtensionResolutionError>),
/// Error raised while checking for breaking extension version mismatch.
ExtensionVersion(WithGenerator<ExtensionBreakingError>),
/// Could not resolve the runtime extensions for the hugr.
RuntimeExtensionResolution(ExtensionError),
}

/// A private package structure implementing the serde traits.
Expand Down
5 changes: 0 additions & 5 deletions hugr-core/src/hugr/validate.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ use crate::types::EdgeKind;
use crate::types::type_param::TypeParam;
use crate::{Direction, Port};

use super::ExtensionError;
use super::internal::PortgraphNodeMap;
use super::views::HugrView;

Expand Down Expand Up @@ -692,10 +691,6 @@ pub enum ValidationError<N: HugrNode> {
/// There are invalid inter-graph edges.
#[error(transparent)]
InterGraphEdgeError(#[from] InterGraphEdgeError<N>),
/// There are errors in the extension deltas.
#[deprecated(note = "Never returned since hugr-core-v0.20.0")]
#[error(transparent)]
ExtensionError(#[from] ExtensionError),
/// A node claims to still be awaiting extension inference. Perhaps it is not acted upon by inference.
#[error(
"{node} needs a concrete ExtensionSet - inference will provide this for Case/CFG/Conditional/DataflowBlock/DFG/TailLoop only"
Expand Down
Loading