Skip to content

Conversation

@zrho
Copy link
Contributor

@zrho zrho commented Jun 3, 2025

Closes #2294.

@hugrbot
Copy link
Collaborator

hugrbot commented Jun 3, 2025

Hey there and thank you for opening this pull request! 👋

It looks like your proposed title indicates a breaking change. If that's the case,
please make sure to include a "BREAKING CHANGE:" footer in the body of the pull request
describing the breaking change and any migration instructions.

@codecov
Copy link

codecov bot commented Jun 3, 2025

Codecov Report

Attention: Patch coverage is 66.93878% with 81 lines in your changes missing coverage. Please review.

Project coverage is 82.07%. Comparing base (2a5413a) to head (c08ac5f).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
hugr-core/src/types/type_param.rs 81.87% 28 Missing and 3 partials ⚠️
hugr-core/src/import.rs 0.00% 22 Missing ⚠️
hugr-core/src/export.rs 0.00% 12 Missing ⚠️
hugr-py/src/hugr/tys.py 58.33% 10 Missing ⚠️
hugr-core/src/extension/resolution/types_mut.rs 33.33% 3 Missing and 1 partial ⚠️
hugr-py/src/hugr/_serialization/tys.py 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2297      +/-   ##
==========================================
- Coverage   82.11%   82.07%   -0.04%     
==========================================
  Files         241      241              
  Lines       43924    44227     +303     
  Branches    39762    40031     +269     
==========================================
+ Hits        36068    36300     +232     
- Misses       5871     5930      +59     
- Partials     1985     1997      +12     
Flag Coverage Δ
python 85.29% <64.70%> (-0.17%) ⬇️
rust 81.73% <67.29%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hugrbot
Copy link
Collaborator

hugrbot commented Jun 3, 2025

This PR contains breaking changes to the public Rust API.

cargo-semver-checks summary

--- failure enum_no_repr_variant_discriminant_changed: enum variant had its discriminant change value ---

Description:
The enum's variant had its discriminant value change. This breaks downstream code that used its value via a numeric cast like `as isize`.
      ref: https://doc.rust-lang.org/reference/items/enumerations.html#assigning-discriminant-values
     impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.41.0/src/lints/enum_no_repr_variant_discriminant_changed.ron

Failed in:
variant TypeArg::Tuple 6 -> 7 in /home/runner/work/hugr/hugr/PR_BRANCH/hugr-core/src/types/type_param.rs:225
variant TypeArg::Variable 7 -> 9 in /home/runner/work/hugr/hugr/PR_BRANCH/hugr-core/src/types/type_param.rs:242
variant TypeArg::Tuple 6 -> 7 in /home/runner/work/hugr/hugr/PR_BRANCH/hugr-core/src/types/type_param.rs:225
variant TypeArg::Variable 7 -> 9 in /home/runner/work/hugr/hugr/PR_BRANCH/hugr-core/src/types/type_param.rs:242

--- failure enum_variant_missing: pub enum variant removed or renamed ---

Description:
A publicly-visible enum has at least one variant that is no longer available under its prior name. It may have been renamed or removed entirely.
      ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
     impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.41.0/src/lints/enum_variant_missing.ron

Failed in:
variant GenericArrayOpDef::unpack, previously in file /home/runner/work/hugr/hugr/BASELINE_BRANCH/hugr-core/src/std_extensions/collections/array/array_op.rs:64

--- failure trait_method_missing: pub trait method removed or renamed ---

Description:
A trait method is no longer callable, and may have been renamed or removed entirely.
      ref: https://doc.rust-lang.org/cargo/reference/semver.html#major-any-change-to-trait-item-signatures
     impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.41.0/src/lints/trait_method_missing.ron

Failed in:
method add_generic_array_unpack of trait GenericArrayOpBuilder, previously in file /home/runner/work/hugr/hugr/BASELINE_BRANCH/hugr-core/src/std_extensions/collections/array/op_builder.rs:69
method add_array_unpack of trait ArrayOpBuilder, previously in file /home/runner/work/hugr/hugr/BASELINE_BRANCH/hugr-core/src/std_extensions/collections/array.rs:217

@zrho zrho force-pushed the zrho/core-sequence-open branch 3 times, most recently from 664c3a1 to 22743b5 Compare June 5, 2025 09:11
@zrho zrho force-pushed the zrho/core-sequence-open branch 2 times, most recently from 497f250 to 5d462e7 Compare June 13, 2025 13:19
@zrho zrho force-pushed the zrho/core-sequence-open branch from 5d462e7 to c08ac5f Compare June 13, 2025 13:27
@zrho
Copy link
Contributor Author

zrho commented Jun 19, 2025

Closed in favour of #2360

@zrho zrho closed this Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow splicing of sublists and subtuples in TypeArg.

3 participants