defer imports in commonly loaded modules #565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DLWoodruff
approved these changes
Aug 30, 2025
Collaborator
Author
|
I am not certain I want to merge this. Need more testing. |
bknueven
force-pushed
the
defer_import
branch
from
23919f5 to
d6200c2
Compare
Collaborator
Author
I am now more certain. But I wonder if we can do something better and defer the import of a given class until its creation. That could end up being cleaner as well because we could avoid having imports in the middle of modules as this PR proposes. As-is, every rank needs to load every class that ends up being used, but in reality they only need their cylinder-local code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.