Skip to content

Correct bug introduced by #530 #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bknueven merged 1 commit into from
Jun 27, 2025
Merged

Correct bug introduced by #530 #536

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions mpisppy/cylinders/spoke.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,8 @@ def register_send_fields(self):
)

def update_if_improving(self, candidate_inner_bound, update_best_solution_cache=True):
if candidate_inner_bound is None:
return False
if update_best_solution_cache:
update = self.opt.update_best_solution_if_improving(candidate_inner_bound)
else:
Expand Down
Loading