Skip to content

Smarter Reduced Cost Spoke #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bknueven merged 3 commits into from
Jun 20, 2025
Merged

Smarter Reduced Cost Spoke #531

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1053ff1
update_nonant_bounds at every calculation
bknueven Apr 8, 2025
c10a127
always try to update the bounds
bknueven Apr 8, 2025
12ffe6f
Merge branch 'main' into rc_spoke_enhancement
bknueven Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion mpisppy/cylinders/reduced_costs_spoke.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,8 @@ def lagrangian(self, need_solution=True, warmstart=False):
self.extract_and_store_reduced_costs()
self.update_bounding_functions(bound)
self.extract_and_store_updated_nonant_bounds(new_dual=True)
else:
self.extract_and_store_updated_nonant_bounds(new_dual=False)
return bound

def extract_and_store_reduced_costs(self):
Expand Down Expand Up @@ -317,6 +319,8 @@ def extract_and_store_updated_nonant_bounds(self, new_dual=False):
Field.NONANT_UPPER_BOUNDS,
)

self.update_nonant_bounds()

def update_nonant_bounds(self):
bounds_modified = 0
send_buf = self.send_buffers[Field.NONANT_LOWER_BOUNDS]
Expand Down Expand Up @@ -350,7 +354,6 @@ def do_while_waiting_for_new_Ws(self, need_solution, warmstart=False):
super().do_while_waiting_for_new_Ws(need_solution=need_solution, warmstart=False)
# might as well see if a tighter upper bound has come along
self.extract_and_store_updated_nonant_bounds(new_dual=False)
self.update_nonant_bounds()

def main(self):
# need the solution for ReducedCostsSpoke
Expand Down
Loading