-
Notifications
You must be signed in to change notification settings - Fork 45
update build system #519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update build system #519
Conversation
…tibility with PEP 517.
….py sdist bdis_wheel' as recommended by https://packaging.python.org/en/latest/discussions/setup-py-deprecated/
…alled as a package." This reverts commit 943d1ae.
|
I understand why the admm wrapper tests are failing - I believe this can be fixed by moving I'm actually not sure why these imports worked in the original |
Thanks for your efforts on this @bwpriest. My preference for fixing this test would be to pull / copy the example it needs into the |
Thanks @bknueven for the suggestion! I'm glad to hear that there is already a protocol in place. I'll take a stab at this shortly. |
DLWoodruff
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! These are valuable changes.
Addresses issue #516 by replacing setup.py with a pyproject.toml. Also updated some Actions and docs accordingly. Will hopefully play nice with ReadTheDocs but there could still be issues.