feat: Add image parameter to create_scheduled_event#1831
Conversation
The parameter was missing at the create command
for more information, see https://pre-commit.ci
|
during fixing this issue, I saw that the payload parameter is actually called |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1831 +/- ##
==========================================
+ Coverage 33.19% 33.20% +0.01%
==========================================
Files 96 96
Lines 18670 18659 -11
==========================================
- Hits 6197 6196 -1
+ Misses 12473 12463 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
The API wrapper should reflect the API, meaning the parameter should be called |
Ok. Will change that as well. Should I attach the commit to this PR? Or should I create a new PR since it is a breaking change? |
|
It's not a breaking change |
Why is it not a breaking change? You would need to change the paramter of For |
|
oh didn't knew we have it there alr We'll target that in another pr. |
|
Will create an issue and attach a PR to it with the breaking changes. |
for more information, see https://pre-commit.ci
Summary
The parameter
coverwas missing in thecreate_scheduled_event()functionInformation
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.