Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pyflakes/checker.py
Original file line number Diff line number Diff line change
Expand Up @@ -529,6 +529,7 @@ def is_typing_overload_decorator(node):
(
isinstance(node, ast.Name) and
node.id in scope and
isinstance(scope[node.id], ImportationFrom) and
scope[node.id].fullName == 'typing.overload'
) or (
isinstance(node, ast.Attribute) and
Expand Down
22 changes: 22 additions & 0 deletions pyflakes/test/test_type_annotations.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,28 @@ def g(s):
return s
""")

def test_not_a_typing_overload(self):
"""regression test for @typing.overload detection bug in 2.1.0"""
self.flakes("""
x = lambda f: f

@x
def t():
pass

y = lambda f: f

@x
@y
def t():
pass

@x
@y
def t():
pass
""", m.RedefinedWhileUnused, m.RedefinedWhileUnused)

@skipIf(version_info < (3, 6), 'new in Python 3.6')
def test_variable_annotations(self):
self.flakes('''
Expand Down