Refactoring, more explicit plugins registering architecture. TODO: Ch… #445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ange documentation
Member
|
Please don't submit pull requests unsolicited, especially when dealing with this. pep8 doesn't want or need a plugin architecture and this has been discussed thoroughly in the past. It defers to flake8 to provide extensibility. |
Contributor
Author
|
Ok, got it! I'm trying to reinvent the wheel :) |
Member
|
👍 :) |
Member
|
:) Also, just from a maintainer standpoint, I'm not sure there are many projects that would accept a commit / PR this big. If you look at the files view, GitHub can't even render the whole diff. :) |
doismellburning
added a commit
to doismellburning/pep8
that referenced
this pull request
Nov 8, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oh, I'm missed class-based checkers