Skip to content

Don't use Bash for setting build variables #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
opdenkamp merged 1 commit into from
Jun 17, 2025
Merged

Don't use Bash for setting build variables #692

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions src/libcec/cmake/SetBuildInfo.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ else()
set(LIB_INFO "")

# add git revision to compile info
find_program(HAVE_GIT_BIN git /bin /usr/bin /usr/local/bin)
if(HAVE_GIT_BIN)
find_program(GIT_BIN git /bin /usr/bin /usr/local/bin)
if(GIT_BIN)
execute_process(COMMAND ${CMAKE_CURRENT_SOURCE_DIR}/cmake/git-rev.sh OUTPUT_VARIABLE GIT_REVISION)
string(STRIP ${GIT_REVISION} GIT_REVISION)
message(STATUS "git found: ${GIT_REVISION}")
Expand All @@ -29,12 +29,12 @@ else()
set(LIB_INFO "${LIB_INFO} compiled on ${BUILD_DATE}")

# add user who built this to compile info
find_program(HAVE_WHOAMI_BIN whoami /bin /usr/bin /usr/local/bin)
find_program(WHOAMI_BIN whoami /bin /usr/bin /usr/local/bin)
if (DEFINED ENV{SOURCE_DATE_EPOCH})
set(BUILD_USER "(reproducible)")
else()
if(HAVE_WHOAMI_BIN)
execute_process(COMMAND bash -c "whoami" OUTPUT_VARIABLE BUILD_USER)
if(WHOAMI_BIN)
execute_process(COMMAND "${WHOAMI_BIN}" OUTPUT_VARIABLE BUILD_USER)
string(STRIP ${BUILD_USER} BUILD_USER)
set(LIB_INFO "${LIB_INFO} by ${BUILD_USER}")
else()
Expand All @@ -46,23 +46,23 @@ else()
if (DEFINED ENV{SOURCE_DATE_EPOCH})
set(BUILD_HOST "(reproducible)")
else()
find_program(HAVE_HOSTNAME_BIN hostname /bin /usr/bin /usr/local/bin)
if(HAVE_HOSTNAME_BIN)
execute_process(COMMAND bash -c "hostname" ARGS -f OUTPUT_VARIABLE BUILD_HOST RESULT_VARIABLE RETURN_HOST)
find_program(HOSTNAME_BIN hostname /bin /usr/bin /usr/local/bin)
if(HOSTNAME_BIN)
execute_process(COMMAND ${HOSTNAME_BIN} -f OUTPUT_VARIABLE BUILD_HOST RESULT_VARIABLE RETURN_HOST)
if (RETURN_HOST)
execute_process(COMMAND bash -c "hostname" OUTPUT_VARIABLE BUILD_HOST)
execute_process(COMMAND ${HOSTNAME_BIN} OUTPUT_VARIABLE BUILD_HOST)
endif()
string(STRIP ${BUILD_HOST} BUILD_HOST)
set(LIB_INFO "${LIB_INFO}@${BUILD_HOST}")
endif()
endif()

# add host info on which this was built to compile info
find_program(HAVE_UNAME_BIN uname /bin /usr/bin /usr/local/bin)
if(HAVE_UNAME_BIN)
execute_process(COMMAND bash -c "uname" ARGS -s OUTPUT_VARIABLE BUILD_SYSNAME)
execute_process(COMMAND bash -c "uname" ARGS -r OUTPUT_VARIABLE BUILD_SYSVER)
execute_process(COMMAND bash -c "uname" ARGS -m OUTPUT_VARIABLE BUILD_SYSARCH)
find_program(UNAME_BIN uname /bin /usr/bin /usr/local/bin)
if(UNAME_BIN)
execute_process(COMMAND "${UNAME_BIN}" -s OUTPUT_VARIABLE BUILD_SYSNAME)
execute_process(COMMAND "${UNAME_BIN}" -r OUTPUT_VARIABLE BUILD_SYSVER)
execute_process(COMMAND "${UNAME_BIN}" -m OUTPUT_VARIABLE BUILD_SYSARCH)
string(STRIP ${BUILD_SYSNAME} BUILD_SYSNAME)
string(STRIP ${BUILD_SYSVER} BUILD_SYSVER)
string(STRIP ${BUILD_SYSARCH} BUILD_SYSARCH)
Expand Down