RPiCECAdapterDetection: Include check that we can set passive mode#678
Merged
opdenkamp merged 1 commit intoPulse-Eight:masterfrom Mar 5, 2025
Merged
Conversation
This allows the firmware driver to be discounted when not available (e.g. using KMS driver) (original commit by popcornmix popcornmix/libcec@b30fc83)
opdenkamp
approved these changes
Mar 5, 2025
| return false; | ||
|
|
||
| bcm_host_init(); | ||
| iResult = vc_cec_set_passive(true); |
Contributor
There was a problem hiding this comment.
would be nicer to rewrite these 4 lines as return (vc_cec_set_passive(true) == VCHIQ_SUCCESS);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the firmware driver to be discounted when not available (e.g. using KMS driver) (original commit by popcornmix popcornmix/libcec@b30fc83)
this is the RPiCECAdapterDetection part of #672