Fix use after free in callbacks with results.#616
Merged
opdenkamp merged 3 commits intoPulse-Eight:masterfrom Feb 14, 2025
Merged
Fix use after free in callbacks with results.#616opdenkamp merged 3 commits intoPulse-Eight:masterfrom
opdenkamp merged 3 commits intoPulse-Eight:masterfrom
Conversation
… is only deleted once even in case of timeout.
|
I've noticed following in my application, which i think may be caused by error that this patch fixes: It happens randomly (well... at least i could not find out exact case when it happens) after menu button on remote controller is used. Last time it happened: |
opdenkamp
added a commit
that referenced
this pull request
Feb 14, 2025
thanks to: @Karlson2k (#527) @bmwiedemann (#553) @ijm7 (#556) @toresbe (#568 #569) @Hedda (#571) @nekopsykose (#599) @Tey (#611) @gmsoft-tuxicoman (#616 #617) @anishsane (#636) @knight-of-ni (#647) @albfan (#655) @heitbaum (#659)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a use-after-free bug in menu state change callback.
in line CECClient.cpp:1656, cb->m_keepResult is check to find out if the callbackWrap needs to be deleted or not.
However in CCECClient::QueueMenuStateChanged, the callback is deleted right after Result().
By the time Report() finishes, the callback is already delted and thus the value if cb->m_keepResult should not be access and can become 0 leading to a double free.