Repository navigation
fix(desktop): keep NeoCode entries separate from T3 Code - #211
Open
PsychedelicShayna wants to merge 2 commits into
Open
PsychedelicShayna wants to merge 2 commits into
PsychedelicShayna wants to merge 2 commits into
Conversation
Use NeoCode-owned Linux desktop entry names so portal and URL registration no longer rewrite upstream's entry. Retain storage and URL schemes, and allow the new capture identities in the shared GNOME service. Cover preservation of an existing upstream desktop file and document safe profile separation. Checks not run: worker assignment leaves verification to main; polite installation admission was blocked by memory pressure. Model: openai-codex/gpt-6.1-sol Co-authored-by: GPT-6.1 Sol <noreply@openai.com>
PsychedelicShayna
added
bug
github-actions
Bot
added
vouch:trusted
Use a NeoCode executable and Debian package name so generated menu files and package ownership remain distinct from upstream T3 Code. Assert the packaging fields in the existing build-configuration test. No build or tests run by this worker. Model: openai-codex/gpt-6.1-sol Co-authored-by: GPT-6.1 Sol <noreply@openai.com>
Thread transfer impact
This comment will update automatically after the next completed run. |
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Use NeoCode-owned Linux desktop-entry names for both packaged and development portal/URL registration. Preserve an existing upstream T3 Code entry in the xdg-utils regression fixture. Permit the new NeoCode capture identities in the GNOME capture service while keeping upstream clients supported.
Linux packages now use
neocodefor both the executable and Debian package identity, rather than sharing upstream'st3codeexecutable/desktop filename and package ownership.Document the separate-backend-home requirement; this change deliberately does not migrate saved data or change URL schemes.
Why
Owner: "I never said replace T3Code, I said add NeoCode to the menu."
NeoCode currently writes
com.t3tools.T3Code.desktop, the upstream-owned filename. The installed hidden handler points at NeoCode, and three local scratch installers also explicitly updated that upstream filename. Those local installers were corrected separately to update only the NeoCode launcher; scratch scripts are not repository files.Default backend state still collides at
~/.t3/userdata. Official upstream v0.1.8 uses a separate Chromium profile, but safe simultaneous launch also requires its ownT3CODE_HOMEand isolated XDG config/data paths while the older NeoCode install remains running. No live userdata was modified, no running NeoCode was stopped, and no upstream binary was launched against the shared home.Testing
Not run locally: delegated assignment reserves code verification for the main agent. Added upstream-file-preservation assertion to the existing isolated xdg-utils test; updated desktop identity expectations. Existing GNOME whitelist tests enumerate every allowed client and therefore cover the new identities when run.
Attempted polite admission for installation: rejected by memory admission (
53.0 GiBoutside polite jobs versus50 GiBbudget, no tier fits; 60-second timeout). No upstream installation or smoke launch was performed. Source-reviewed official v0.1.8DesktopConfig,DesktopStatePaths,DesktopUserDataand desktop handler implementation for isolation options.Signed commit verified with
git verify-commit HEAD.vp checkandvpr typecheckpass (CI runs both; locally run only the checks for the touched scope, perAGENTS.md› Verifying)No rendered UI change; menu/runtime identity only. No screenshots captured. Leave this PR unmerged as explicitly requested.
Model: openai-codex/gpt-6.1-sol. Harness: NeoPi.