Repository navigation
fix(web): keep Appearance font discovery responsive - #131
Merged
Merged
Conversation
Stop measuring every installed font when closed monospace pickers mount. Only classify fonts after opening a picker, yield between short measurement batches, cancel on close, and reuse completed measurements across code and terminal pickers and Appearance remounts. Saved font preferences and the live previews remain unchanged. Add isolated regression coverage for yielding to other UI work, cancellation, family order, and measurement reuse. No tests, typechecks, lint, formatters, builds, or GUI checks were run, as required by the parent assignment. Integrated verification belongs to the parent. Model: openai-codex/gpt-6.1-sol Co-authored-by: GPT-6.1 Sol <noreply@openai.com>
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
Record the upstream picker change and its fork-owned scheduler in the touch ledger. Installed baseline profiling observed a 7,807 ms renderer task while opening Appearance with 554 installed font families. The repair avoids that closed-picker scan and yields during an opened picker scan. Focused installedMonospaceFonts.test.ts passed 3 tests using the worktree-local Vite runner. Web typecheck and targeted lint/format checks passed. The first bootstrap-root runner attempt failed before collecting tests; no assertion failure was hidden. Installed after-proof follows the nightly artifact batch. Refs #126 Model: openai-codex/gpt-6-astra Co-authored-by: GPT-6 Astra <noreply@openai.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
GPT-6.1 Sol on behalf of PsychedelicShayna
What
Keep closed monospace font pickers from classifying every installed family when Appearance opens. When a picker opens, classify fonts in cancellable, approximately 8ms batches and reuse completed measurements across pickers and remounts. Display loading status while classification runs. Saved font choices, setting writes and live previews are unchanged.
Why
Refs #126.
The existing closed-picker render filters the full installed-font catalog through a canvas probe that can perform 32 measurements per family. Already-granted font permission starts enumeration on mount, so opening Appearance enters that synchronous work without opening a picker. Remounting repeats it. The repair removes that work from closed-picker rendering and yields to input between opened-picker batches.
Testing
Installed nightly source
3ca07c37659338f9fde4142baf50d20f09e4c5d8, version0.0.42-nightly.20261022.39742893669.1. The NeoCode launcher now selects this versioned AppRun; the previous artifact and launcher backup remain available. AppImage SHA256:bde7d6dce6a2928cedf8104ffcf912d8dafb75d59b65f79a052aa65b671bc113.Proof used the actual installed Electron artifact, normal shell hydration and private state on Xvfb
:10. The owner's live window, database and wallet were not used or restarted.PR #131 is delivered. Same installed-font catalog in both measurements: 554 families, 2,817 faces.
This is one measured before/after case, not a general benchmark. The after-proof also typed into the opened monospace picker, closed it during classification, navigated away and back with no long tasks in that interaction window, completed classification, selected DejaVu Sans Mono, retained it across navigation, and restored the default Liberation Mono.
Three focused scheduler tests, web types, targeted lint and formatting passed. The initial bootstrap-root Vite runner failed before collecting tests; the corrected worktree-local runner passed.
Before image · After image · Interaction recording · Before profile · After profile · Installed receipt.
vp checkandvpr typecheckpass (CI runs both; locally run only the checks for the touched scope, perAGENTS.md› Verifying). Focused checks above; no full suite.Model: openai-codex/gpt-6.1-sol. Harness: NeoPi.
Installed integration: GPT-6 Astra in NeoPi; focused execution by GPT-6 Luna.