Skip to content

fix(pull-requests): scope project lists to the origin fork - #130

Merged
PsychedelicShayna merged 2 commits into
nightlyfrom
fix/fork-pull-requests
Oct 22, 2026
Merged

PsychedelicShayna merged 2 commits into
nightlyfrom
fix/fork-pull-requests

Conversation

@PsychedelicShayna

@PsychedelicShayna PsychedelicShayna commented Oct 22, 2026 •

Copy link
Copy Markdown
Owner

What

Resolve project repository identity from origin before upstream, so a checkout of a fork lists that fork's pull requests. Keep the existing fallbacks when origin is absent.

Read a selected project directly through its explicit repository scope. Reject saved GitHub rows that no longer match the project's current repository, including Authored and Reviewing priority groups. Keep All Projects batching and multi-environment routing.

Why

Refs #128.

The resolver preferred upstream over origin. GitHub requests already use explicit repository selectors and the verified account login, but received the upstream repository identity. Saved rows were checked by project ID, host and state only, so correcting the remote could still leave upstream rows visible until the next answer. A selected unindexed fork also incurred a host search before repeating its repository search.

Testing

Installed nightly source 3ca07c37659338f9fde4142baf50d20f09e4c5d8, version 0.0.42-nightly.20261022.39742893669.1. The NeoCode launcher now selects this versioned AppRun; the previous artifact and launcher backup remain available. AppImage SHA256: bde7d6dce6a2928cedf8104ffcf912d8dafb75d59b65f79a052aa65b671bc113.

Proof used the actual installed Electron artifact, normal shell hydration and private state on Xvfb :10. The owner's live window, database and wallet were not used or restarted.

PR #130 is delivered. The same private profile/project showed can1357/oh-my-pi before the repair and psychedelicshayna/neopi after it. The explicit Authored filter now shows the owner's real fork PRs. Explicit project selection with all PR states remains on the fork; upstream rows are absent. GitHub requests in this proof were read-only.

The four focused repository/query/filter files passed 431 tests. The corrected cross-environment fixture then passed 128 tests in its affected web file; web types passed. Targeted lint/format passed. Server types retain only the disclosed serverSettings.test.ts:235 baseline diagnostic.

Before · After · Authored · Explicit project/all states · Structured proof.


  • vp check and vpr typecheck pass (CI runs both; locally run only the checks for the touched scope, per AGENTS.md › Verifying). Focused checks above; no full suite.
  • Tested locally. Installed private-state proof and focused checks are recorded above.
  • Before/after images (video for motion) uploaded to GitHub for UI changes, not committed (if user-facing). Linked above.

Model: openai-codex/gpt-6.1-sol. Harness: NeoPi.

Installed integration: GPT-6 Astra in NeoPi; focused execution by GPT-6 Luna.

Resolve project repository identity from origin before upstream. Keep the existing upstream and alphabetical fallbacks for checkouts without origin. Selected-project reads target that repository directly instead of making a host search before repeating the repository search for an unindexed fork.

Reject saved GitHub rows whose repository no longer matches their project's current origin, including authored and reviewing priority groups. Keep environment identity in that comparison and leave other providers' server-side host refinement alone. The current GitHub account still comes from the existing verified credential lookup.

Add focused resolver, authored-query, selected-project listing and carried-row regressions. Tests, typechecks, lint, formatting and GUI checks were not run, as assigned. Commit hooks were skipped because they invoke vp staged; the parent owns integrated verification after the polite relay is restored.

Model: openai-codex/gpt-6.1-sol
Co-authored-by: GPT-6.1 Sol <noreply@openai.com>
@PsychedelicShayna PsychedelicShayna added bug Something isn't working priority: p1 High value or prerequisite for several issues agent: finished The agent's part is done; not necessarily mergeable labels Oct 22, 2026
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M labels Oct 22, 2026
@github-actions

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ The exact PR base did not have a successful artifact. Baseline uses the latest successful main measurement shown below.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 13.5 KiB 13.5 KiB −38 B (−0.3%) 15.1 KiB ✅
Codex Thread snapshot wire 7.1 KiB 7.1 KiB +7 B (+0.1%) 7.3 KiB ✅
Codex Live turn WebSocket wire 6.4 KiB 6.4 KiB −45 B (−0.7%) 7.8 KiB ✅
Codex Live turn WebSocket decoded 56.3 KiB 56.2 KiB −88 B (−0.2%) 66.4 KiB ✅
Codex Live turn messages 10 8 −2 (−20.0%) 21 ✅
Claude Total thread wire 13.5 KiB 13.5 KiB +1 B (+0.0%) 15.1 KiB ✅
Claude Thread snapshot wire 7.1 KiB 7.1 KiB 0 B (0.0%) 7.3 KiB ✅
Claude Live turn WebSocket wire 6.4 KiB 6.4 KiB +1 B (+0.0%) 7.8 KiB ✅
Claude Live turn WebSocket decoded 57.0 KiB 57.0 KiB 0 B (0.0%) 66.4 KiB ✅
Claude Live turn messages 9 9 0 (0.0%) 21 ✅

Baseline: 3c10e1c · PR result: 726e5d4 · Source CI: failure

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.9 KiB
  • Claude decoded thread snapshot: 114.6 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Correct the new cross-environment fixture IDs to the existing branded contract and format the two affected test files. Record the origin-first repository identity, selected-repository query and stale-row filtering seams in the fork ledger.

The four focused repository/PR files passed 431 tests. After the fixture correction, pullRequestList.logic.test.ts passed 128 tests and the web typecheck passed. Targeted lint passed; the server typecheck retains only the known serverSettings.test.ts:235 preferSchemaOverJson baseline diagnostic. Installed PR-page proof follows the nightly desktop batch.

Refs #128

Model: openai-codex/gpt-6-astra
Co-authored-by: GPT-6 Astra <noreply@openai.com>
@PsychedelicShayna
PsychedelicShayna merged commit d739595 into nightly Oct 22, 2026
15 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent: finished The agent's part is done; not necessarily mergeable bug Something isn't working priority: p1 High value or prerequisite for several issues size:M vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant