Repository navigation
fix(web): refresh virtual model rows after preference changes - #101
Merged
Merged
Conversation
Include the virtual rows' external render state in LegendList invalidation. A model object can stay identical when its favorite, visibility, filter context or custom editor changes. The list must refresh the controls and their callbacks rather than retaining the previous render. The installed #99 proof reproduced a saved favorite whose button remained unchanged until the settings section remounted. That distinguishes stale row rendering from a failed settings write. Keep the bounded list and full-catalog behavior; no persistence or default changes. Targeted formatting passed. The existing two focused model files passed all five tests on the preceding integrated head; they are unchanged here. Web typecheck and the repaired installed GUI interaction pass are recorded in the PR when complete. Model: openai-codex/gpt-6-astra Co-authored-by: GPT-6 Astra <noreply@openai.com>
PsychedelicShayna
added
bug
github-actions
Bot
added
vouch:trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Refresh cached model-setting rows when their favorite/visibility state, filtering context, custom editor inputs or handlers change. Keep the existing bounded virtual list.
Why
Fix-forward for #99, refs #67. Installed GUI proof showed the favorite was saved correctly but the row's star/button stayed stale until the settings section remounted. Model identity alone cannot invalidate that render. This repairs that concrete regression without changing persistence or provider defaults.
Testing
vp checkandvpr typecheckpass (CI runs both; locally run only the checks for the touched scope, perAGENTS.md› Verifying) — only scoped checks; web typecheck and targeted formatting passed; no full-repo checks.GPT-6 Astra (openai-codex/gpt-6-astra), NeoPi harness.