refactor: modify rewriter structure to allow method chaining and history tracking#237
Merged
Brendan-Reid1991 merged 231 commits intomainfrom Jul 2, 2025
Merged
refactor: modify rewriter structure to allow method chaining and history tracking#237Brendan-Reid1991 merged 231 commits intomainfrom
Brendan-Reid1991 merged 231 commits intomainfrom
Conversation
…bout interactive tools
… + transitive resources
dexter2206
requested changes
Jul 1, 2025
Contributor
dexter2206
left a comment
dexter2206
left a comment
There was a problem hiding this comment.
Good stuff, I only found minor issues and left some improvement suggestions.
We talked with @Brendan-Reid1991 off the Github and agreed that maybe revert_to method is not how we want to interact with history. Therefore, all the comments I left regarding problems with this methods can be ignored.
…mproved docstrings
dexter2206
approved these changes
Jul 2, 2025
Contributor
dexter2206
left a comment
dexter2206
left a comment
There was a problem hiding this comment.
LGTM!
For posterity: we agreed that factory functions for constructing rewriter can be implemented in another PR, all my other comments have been addressed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactor of the rewriter classes to be data classes instead of standard python classes.
Please verify that you have completed the following steps