Feature/254 strengthen import rules #620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #620 +/- ##
==========================================
+ Coverage 75.63% 75.77% +0.13%
==========================================
Files 518 523 +5
Lines 16135 16199 +64
==========================================
+ Hits 12204 12275 +71
+ Misses 3931 3924 -7
Continue to review full report at Codecov.
|
acoglio
reviewed
Feb 8, 2021
grammar/src/leo.pest
Outdated
|
|
||
| // Declared in imports/import.rs | ||
| import = { "import " ~ package ~ LINE_END} | ||
| import = { "import " ~ package_type ~ LINE_END} |
Collaborator
There was a problem hiding this comment.
You might consider using package_or_packages instead of package_type, to avoid any potential confusion with Leo types.
Member
There was a problem hiding this comment.
+1 on this, it seems that could help improve readability
acoglio
previously approved these changes
Feb 8, 2021
Collaborator
acoglio
left a comment
acoglio
left a comment
There was a problem hiding this comment.
Looks good to me. I just left a very minor comment for consideration in the Pest file.
howardwu
approved these changes
Feb 11, 2021
collinc97
approved these changes
Feb 11, 2021
Collaborator
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 11, 2021
598: [Feature] 374 circuit self access r=collinc97 a=gluax Feature resolves #374. At the grammar level the following syntax is no longer allowed on self: ``` self[0]; self(); ``` Syntax that is allowed at the grammar level is: ``` console.log("b: {}", self::b); console.log("hmm: {}",self::hmm()); self.hello(); console.log("access: {}", self.a); ``` Note that these changes are only at the grammar level only. 620: Feature/254 strengthen import rules r=collinc97 a=gluax Grammar changes are a bit different than what was suggested in the original feature request #254. However, it should be logically equivalent and I think makes more sense on the rust side. Closes #254 Co-authored-by: gluaxspeed <[email protected]> Co-authored-by: Howard Wu <[email protected]>
Collaborator
|
bors r- |
Contributor
|
Canceled. |
Collaborator
|
bors r+ |
Contributor
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grammar changes are a bit different than what was suggested in the original feature request #254. However, it should be logically equivalent and I think makes more sense on the rust side.
Closes #254