Skip to content

Conversation

@mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Jan 2, 2024

Release/1.0.0

@mocsharp mocsharp added the build label Jan 2, 2024
@mocsharp mocsharp added this to the 1.0.0 milestone Jan 2, 2024
@mocsharp mocsharp self-assigned this Jan 2, 2024
mocsharp and others added 4 commits January 2, 2024 15:03
Signed-off-by: Victor Chang <[email protected]>
* Throw any error from MinIO when listing objects
* Capture ListObjectsAsync exceptions in VerifyObjectExistsAsync
* Configure minio client timeout
* Throw VerifyObjectsException on error
* Convert MinIO exception with custom exceptions
* Update API doc

Signed-off-by: Victor Chang <[email protected]>
* Upgrade to .NET 8

Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
@codecov
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (32d7dc0) 78.82823% compared to head (13615ab) 79.40979%.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #284         +/-   ##
===================================================
+ Coverage   78.82823%   79.40979%   +0.58155%     
===================================================
  Files             38          38                 
  Lines           1502        1491         -11     
  Branches          78          78                 
===================================================
  Hits            1184        1184                 
+ Misses           279         268         -11     
  Partials          39          39                 
Flag Coverage Δ
unittests 79.40979% <100.00000%> (+0.58155%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/Plugins/MinIO/MinIoClientFactory.cs 42.85714% <100.00000%> (ø)
src/Plugins/MinIO/MinIoStartup.cs 88.88889% <ø> (ø)
src/Plugins/MinIO/MinIoStorageService.cs 68.63469% <ø> (ø)
...ns/MinIO/Tests/Integration/MinIoHealthCheckTest.cs 100.00000% <100.00000%> (ø)
...ins/MinIO/Tests/Integration/MinIoStorageFixture.cs 67.44186% <ø> (ø)
...MinIO/Tests/Integration/MinIoStorageServiceTest.cs 99.15966% <100.00000%> (ø)
...MinIO/Tests/Integration/StorageAdminServiceTest.cs 91.11111% <100.00000%> (ø)
...gins/MinIO/Tests/Unit/MinIoAdminHealthCheckTest.cs 100.00000% <100.00000%> (ø)
...c/Plugins/MinIO/Tests/Unit/MinIoHealthCheckTest.cs 100.00000% <100.00000%> (ø)
src/Plugins/MinIO/Tests/Unit/MinIoStartupTest.cs 100.00000% <ø> (ø)
... and 6 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32d7dc0...13615ab. Read the comment docs.

@mocsharp mocsharp requested a review from neildsouth January 4, 2024 01:42
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
@mocsharp mocsharp merged commit 654e943 into main Jan 5, 2024
@github-actions
Copy link

github-actions bot commented Jan 5, 2024

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants