Skip to content

Conversation

@KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Sep 22, 2025

Part of #8569

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Yun Liu <[email protected]>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 22, 2025

Walkthrough

Updates CITATION.cff metadata: bumps date-released from 2025-06-13 to 2025-09-22 and version from "1.5.0" to "1.5.1". No other fields changed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description does not follow the repository template because it lacks the required "### Description" section with a brief explanation of what changed and why; it only contains "Part of #8569" and the Types of changes checklist, leaving reviewers without a clear summary. Please add a "### Description" paragraph summarizing the specific changes (e.g., CITATION.cff version 1.5.0 → 1.5.1 and date updated to 2025-09-22), the rationale, any testing performed, and update the checklist or link the related issue appropriately.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title "Update citation for 1.5.1" is concise and accurately summarizes the primary change (bumping CITATION.cff version/date to 1.5.1), so it clearly reflects the main changeset.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: Yun Liu <[email protected]>
@KumoLiu KumoLiu requested a review from ericspod September 22, 2025 17:43
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Sep 22, 2025

/build

@KumoLiu KumoLiu enabled auto-merge (squash) September 22, 2025 17:43
Copy link
Member

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed this earlier, thanks for catching it!

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
CITATION.cff (1)

135-135: Use bare DOI string, not a URL, per CFF spec.

The doi field should be the DOI (no https://doi.org/ prefix).

-  doi: "https://doi.org/10.48550/arXiv.2211.02701"
+  doi: "10.48550/arXiv.2211.02701"
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 9c6d819 and 44bd967.

📒 Files selected for processing (1)
  • CITATION.cff (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (19)
  • GitHub Check: min-dep-os (ubuntu-latest)
  • GitHub Check: min-dep-pytorch (2.6.0)
  • GitHub Check: min-dep-os (macOS-latest)
  • GitHub Check: min-dep-pytorch (2.7.1)
  • GitHub Check: min-dep-py3 (3.10)
  • GitHub Check: min-dep-pytorch (2.8.0)
  • GitHub Check: min-dep-py3 (3.9)
  • GitHub Check: min-dep-os (windows-latest)
  • GitHub Check: min-dep-pytorch (2.5.1)
  • GitHub Check: min-dep-py3 (3.12)
  • GitHub Check: min-dep-py3 (3.11)
  • GitHub Check: flake8-py3 (mypy)
  • GitHub Check: packaging
  • GitHub Check: quick-py3 (ubuntu-latest)
  • GitHub Check: quick-py3 (windows-latest)
  • GitHub Check: build-docs
  • GitHub Check: flake8-py3 (codeformat)
  • GitHub Check: quick-py3 (macOS-latest)
  • GitHub Check: flake8-py3 (pytype)
🔇 Additional comments (1)
CITATION.cff (1)

9-10: Version/date bump to 1.5.1 (2025-09-22) — verify cross-repo consistency

CITATION.cff shows date-released: 2025-09-22 and version: "1.5.1" (lines 9–10).

  • Confirm canonical version holders and docs match: pyproject.toml, setup.py / setup.cfg, monai/_version.py, docs/source/conf.py, and the Git tag/release date.
  • Run a full repo search for the literal token 1.5.1 (e.g., rg -nP --hidden -S '\b1.5.1\b' .) — ripgrep in the sandbox reported "No files were searched".
  • Validate CITATION.cff locally with cffconvert (sandbox import failed); ensure the recorded date equals the actual release/tag date.

@KumoLiu KumoLiu merged commit 53382d8 into Project-MONAI:dev Sep 22, 2025
27 checks passed
arthurdjn pushed a commit to arthurdjn/MONAI that referenced this pull request Sep 29, 2025
Part of Project-MONAI#8569

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: Yun Liu <[email protected]>
arthurdjn pushed a commit to arthurdjn/MONAI that referenced this pull request Sep 29, 2025
Part of Project-MONAI#8569

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: Yun Liu <[email protected]>
@KumoLiu KumoLiu deleted the update-citation branch October 10, 2025 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants