-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix build failure by pinning pyamg to versions below 5.3.0 #8548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Yun Liu <[email protected]>
WalkthroughConstrained the pyamg dependency to "pyamg>=5.0.0, <5.3.0" in three files: requirements-dev.txt, docs/requirements.txt, and setup.cfg (in two extras_require entries). No other dependency or public/exported-API changes. Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Assessment against linked issues
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
|
/build |
Signed-off-by: Yun Liu <[email protected]>
|
/build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
docs/requirements.txt (1)
43-43: Apply narrow pyamg pin across all specs
Multiple files pinpyamg>=5.0.0, <5.3.0(setup.cfg lines 90 & 177; requirements-dev.txt line 62; docs/requirements.txt line 43). For each, use a narrower exclude (!=5.3.0) or a py39-only pin (Option A/B) and add a comment (e.g.# Temporary pin for #8547: pyamg 5.3.0 fails on Python 3.9) to document the rationale.setup.cfg (1)
90-90: Narrow pyamg pin to minimize blast radiuspyamg>=5.0.0,<5.3.0 is applied in both extras (lines 90 & 178); consider instead either:
pyamg>=5.0.0,!=5.3.0- or use PEP 508 markers:
pyamg<5.3.0; python_version=="3.9"
pyamg>=5.0.0; python_version!="3.9"
and add an inline comment—e.g. “Temporary pin for #8547: pyamg 5.3.0 fails on Python 3.9”—to document the reason.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Knowledge Base: Disabled due to Reviews > Disable Knowledge Base setting
📒 Files selected for processing (2)
docs/requirements.txt(1 hunks)setup.cfg(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (19)
- GitHub Check: min-dep-os (macOS-latest)
- GitHub Check: min-dep-os (ubuntu-latest)
- GitHub Check: min-dep-py3 (3.12)
- GitHub Check: min-dep-os (windows-latest)
- GitHub Check: min-dep-py3 (3.10)
- GitHub Check: min-dep-py3 (3.9)
- GitHub Check: min-dep-py3 (3.11)
- GitHub Check: flake8-py3 (pytype)
- GitHub Check: build-docs
- GitHub Check: min-dep-pytorch (2.5.1)
- GitHub Check: flake8-py3 (mypy)
- GitHub Check: min-dep-pytorch (2.8.0)
- GitHub Check: min-dep-pytorch (2.6.0)
- GitHub Check: min-dep-pytorch (2.7.1)
- GitHub Check: flake8-py3 (codeformat)
- GitHub Check: quick-py3 (windows-latest)
- GitHub Check: quick-py3 (macOS-latest)
- GitHub Check: quick-py3 (ubuntu-latest)
- GitHub Check: packaging
ericspod
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, when we drop Python 3.9 support we'll revisit this and other constraints. Thanks!
Fixes #8547
Description
Fix build failure by pinning pyamg to versions below 5.3.0
https://pypi.org/project/pyamg/5.3.0/#files
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.