Skip to content

Conversation

@KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Aug 28, 2025

Fixes #8547

Description

Fix build failure by pinning pyamg to versions below 5.3.0

https://pypi.org/project/pyamg/5.3.0/#files

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Yun Liu <[email protected]>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 28, 2025

Walkthrough

Constrained the pyamg dependency to "pyamg>=5.0.0, <5.3.0" in three files: requirements-dev.txt, docs/requirements.txt, and setup.cfg (in two extras_require entries). No other dependency or public/exported-API changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Assessment against linked issues

Objective Addressed Explanation
Resolve build failure with pyamg==5.3.0 on Python 3.9 (#8547)
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@KumoLiu
Copy link
Contributor Author

KumoLiu commented Aug 28, 2025

/build

@KumoLiu KumoLiu requested a review from ericspod August 28, 2025 15:57
@KumoLiu KumoLiu enabled auto-merge (squash) August 28, 2025 15:57
Signed-off-by: Yun Liu <[email protected]>
@KumoLiu KumoLiu requested a review from Nic-Ma as a code owner September 1, 2025 05:50
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Sep 1, 2025

/build

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
docs/requirements.txt (1)

43-43: Apply narrow pyamg pin across all specs
Multiple files pin pyamg>=5.0.0, <5.3.0 (setup.cfg lines 90 & 177; requirements-dev.txt line 62; docs/requirements.txt line 43). For each, use a narrower exclude (!=5.3.0) or a py39-only pin (Option A/B) and add a comment (e.g. # Temporary pin for #8547: pyamg 5.3.0 fails on Python 3.9) to document the rationale.

setup.cfg (1)

90-90: Narrow pyamg pin to minimize blast radius

pyamg>=5.0.0,<5.3.0 is applied in both extras (lines 90 & 178); consider instead either:

  • pyamg>=5.0.0,!=5.3.0
  • or use PEP 508 markers:
    pyamg<5.3.0; python_version=="3.9"
    pyamg>=5.0.0; python_version!="3.9"
    and add an inline comment—e.g. “Temporary pin for #8547: pyamg 5.3.0 fails on Python 3.9”—to document the reason.
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Knowledge Base: Disabled due to Reviews > Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between e07f4a1 and d9f4a13.

📒 Files selected for processing (2)
  • docs/requirements.txt (1 hunks)
  • setup.cfg (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (19)
  • GitHub Check: min-dep-os (macOS-latest)
  • GitHub Check: min-dep-os (ubuntu-latest)
  • GitHub Check: min-dep-py3 (3.12)
  • GitHub Check: min-dep-os (windows-latest)
  • GitHub Check: min-dep-py3 (3.10)
  • GitHub Check: min-dep-py3 (3.9)
  • GitHub Check: min-dep-py3 (3.11)
  • GitHub Check: flake8-py3 (pytype)
  • GitHub Check: build-docs
  • GitHub Check: min-dep-pytorch (2.5.1)
  • GitHub Check: flake8-py3 (mypy)
  • GitHub Check: min-dep-pytorch (2.8.0)
  • GitHub Check: min-dep-pytorch (2.6.0)
  • GitHub Check: min-dep-pytorch (2.7.1)
  • GitHub Check: flake8-py3 (codeformat)
  • GitHub Check: quick-py3 (windows-latest)
  • GitHub Check: quick-py3 (macOS-latest)
  • GitHub Check: quick-py3 (ubuntu-latest)
  • GitHub Check: packaging

Copy link
Member

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, when we drop Python 3.9 support we'll revisit this and other constraints. Thanks!

@KumoLiu KumoLiu merged commit d4ba52e into Project-MONAI:dev Sep 1, 2025
27 checks passed
@KumoLiu KumoLiu deleted the fix-pyamg branch September 1, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failed for pyamg==5.3.0 in python 3.9

2 participants