Merged
Conversation
brianlagunas
requested changes
Aug 5, 2024
dansiegel
force-pushed
the
dev/ds/module-fix
branch
from
3100f41 to
c7bf3f8
Compare
Member
Author
|
@Mergifyio backport release/stable/9.0 |
✅ Backports have been createdDetails
|
brianlagunas
approved these changes
Aug 14, 2024
dansiegel
added a commit
that referenced
this pull request
Aug 14, 2024
…9.0/pr-3219 Modularity Fix (backport #3219)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This updates the registration logic for the Modules to avoid a static registration flag. This now is updated to use TryRegister.
This also updates the ModuleCatalog for MAUI/Uno to use a constructor that takes an
IEnumerable<IModuleInfo>thus allowing instances ofIModuleInfoto be registered with the container and later injected into the ModuleCatalog. NOTE you still need to call ConfigureModuleCatalog or register the services yourself if you prefer to use DIBugs Fixed
API Changes
Behavioral Changes
IModuleInfo can now be injected with DI into the ModuleCatalog on MAUI and Uno. This was not applied to WPF as we are still shipping Unity Container which does not support this.