Update RegionNavigationRegistrationExtensions.cs#3146
Merged
dansiegel merged 1 commit intoPrismLibrary:masterfrom May 24, 2024
Merged
Update RegionNavigationRegistrationExtensions.cs#3146dansiegel merged 1 commit intoPrismLibrary:masterfrom
dansiegel merged 1 commit intoPrismLibrary:masterfrom
Conversation
My previous submission made RegisterForNavigationWithViewModel public, after more thought it makes sense that it would be private and instead an override of RegisterForRegionNavigation without the strong typing is more descriptive and conveys the intent better.
dansiegel
approved these changes
May 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My previous submission made RegisterForNavigationWithViewModel public, after more thought it makes sense that it would be private and instead an override of RegisterForRegionNavigation without the strong typing is more descriptive and conveys the intent better.
## Description of Change
Reverted RegisterForNavigationWithViewModel to be private and created overrides for RegisterForRegionNavigation that call existing method with non generic parameters.
Tests were not created as this doesn't change anything functionally that is not already covered.
PR Checklist