Update RegionNavigationRegistrationExtensions.cs#3145
Merged
dansiegel merged 1 commit intoPrismLibrary:masterfrom May 22, 2024
Merged
Update RegionNavigationRegistrationExtensions.cs#3145dansiegel merged 1 commit intoPrismLibrary:masterfrom
dansiegel merged 1 commit intoPrismLibrary:masterfrom
Conversation
Allow for registering a view for navigation using type. This method already exists but is currently private.
Member
|
@jpislas can you please give us some context on why you feel this is needed as part of the public API? |
Contributor
Author
@dansiegel I register my views using attributes/reflection and don't have access to strongly type them so I end up having to work around it. Its also the way it is set up for standard non region based navigation registration, so it would be consistent with existing functionality. For example: |
dansiegel
approved these changes
May 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow for registering a view for navigation using type. This method already exists but is currently private. This is existing function so no tests created.
## Description of Change
Make existing function public.
Changed:
PR Checklist