Added snapshot plugin tests #3524
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Sooo, it seems like this is blocked by #3408. |
Member
Author
|
Resolved by 5f5b6d2 in v2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since @JaKXz asked for Light Highlight tests in #3518, I added some. However, I thought that having a bunch of test HTML in source files wasn't ideal, so I added snapshot testing. Since this added a dependency and made quite a few changes, I didn't want this to be part of #3518, hence this PR.
Snapshots are pretty easy to use with
util.assert. If theexpectedoption is missing, it will use snapshots.Right now, only the tests for Line Highlight and Highlight Keyword use snapshots. The other tests did not have long enough test HTML to warrant snapshots IMO.