Add span with command-line-(input|output) class to command-line plugin lines#3312
Merged
RunDevelopment merged 3 commits intoPrismJS:masterfrom Feb 2, 2022
Merged
Conversation
Allows distinction between input and output for custom styling, e.g. setting user-select: none; for .command-line-output.
RunDevelopment
requested changes
Feb 2, 2022
Member
There was a problem hiding this comment.
Sorry for the delay @at055612!
The PR in itself looks good. I just suggest using different CSS classes in my comment.
Co-authored-by: Michael Schmidt <msrd0000@gmail.com>
Contributor
Author
|
Accepted your css class name change. I have re-generated the minified js. |
Member
|
Thank you for contributing @at055612! |
Contributor
Author
|
Thanks for merging this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently it is not possible to distinguish between input and output, unless all input has some kind of highlighting on it. This change wraps each line with a span and class to indicate whether it is input or output.
Reasons for needing to do this so that it is possible to:
user-select: none;for output linesFor example
The above HTML was from
