Skip to content

gulp: Improved inlineRegexSource #2296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 8, 2020
Merged

gulp: Improved inlineRegexSource #2296

merged 2 commits into from
Apr 8, 2020

Conversation

@RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Apr 8, 2020

This makes some improvements to the inlineRegexSource function:

  1. Do not escape /. It only has to be escaped in RegExp literals.
  2. Allow spaces between the RegExp literal and the .source.
  3. Replace the [\s\S] match-all character class with [^]. They both do the same thing but the latter is shorter.
  4. There now has to be at least character in the RegExp literal. Before, the comment //.source was replaced with "".

@RunDevelopment RunDevelopment merged commit abb800d into PrismJS:master Apr 8, 2020
@RunDevelopment RunDevelopment deleted the gulp-inline-regex-improvement branch April 8, 2020 22:39
quentinvernot pushed a commit to TankerHQ/prismjs that referenced this pull request Sep 11, 2020
@RunDevelopment @quentinvernot
gulp: Improved inlineRegexSource (PrismJS#2296)
baba171
@RunDevelopment RunDevelopment mentioned this pull request Oct 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mAAdhaTTah mAAdhaTTah mAAdhaTTah approved these changes

Assignees

No one assigned

Labels

enhancement needs review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RunDevelopment @mAAdhaTTah