Skip to content

Conversation

@tianrui-wei
Copy link
Contributor

This PR prevents latch inference by assigning a default value to msg_send_data_size_S4

Signed-off-by: Tianrui Wei <[email protected]>
@tianrui-wei
Copy link
Contributor Author

cc @Jbalkind @fei-g
The latch inference seems to come from a39066a. Would you have any insight on why the comments was inserted?

@fei-g
Copy link
Contributor

fei-g commented Oct 9, 2023

I don't remember exactly why did I comment that out.. Just checked the L15 decoder, and I found that it didn't look into the data_size field. I think in L15 pipeline it will use the data size stored in MSHR. So, we are okay to set the default data_size to 0. But If you have other modules that need the data_size info, the best way might be just uncomment those lines back (or set default data size to data_size_S4_f).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants