Skip to content

Porting more to JSX and typescript#284

Merged
mrjvs merged 33 commits intodevfrom
feat/even-more-jsx
Jan 16, 2026
Merged

Porting more to JSX and typescript#284
mrjvs merged 33 commits intodevfrom
feat/even-more-jsx

Conversation

@mrjvs
Copy link
Contributor

@mrjvs mrjvs commented Jan 7, 2026

Changes:

  • Moved everything in routes/web to typescript
    • Ported login.ejs to JSX
    • It still uses error.ejs for error rendering
    • Also updated middleware to use JSX for login page rendering
  • Ported redisCache.js to typescript
    • Fixed bug with expiration, library updated the signature for expiration setting
    • Fixed another bug where false was returned instead of null
  • Ported juxt-web/routes/index.js and juxt-web/index.js to typescript
  • Ported server.js to typescript
    • Removed ttl option from session(), the types indicate that isn't a thing with the current library version
    • Added types for cookie-parser lib
  • Ported routes/console/show.js to typescript
    • Ported first_run.ejs to JSX
      • Moved the embedded CSS and JS to dedicated files
    • It still uses guest_notice.ejs, still needs porting later
    • Removed the check for the 1000000 pid. It wasn't possible to reach.
  • Ported routes/console/web.js to typescript
  • Ported endpoint mongoose model to typescript
  • Ported report mongoose model to typescript
  • Ported settings mongoose model to typescript
  • Updated web.css so tabs are horizontally stacked instead of vertical

Notes:

  • I tested all changes
  • There seemed to be a lot of broken references to JS and CSS files in first_run.ejs - I wonder if it worked in the first place

Resolves a part of #12

@mrjvs mrjvs marked this pull request as ready for review January 14, 2026 13:17
@mrjvs mrjvs requested a review from ashquarky January 14, 2026 13:17
@mrjvs
Copy link
Contributor Author

mrjvs commented Jan 14, 2026

@ashquarky I tested everything, everything works now! Should be ready for a review

Copy link
Member

@ashquarky ashquarky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You picked all the weird ones with the custom head tags to do!

Good stuff all around

@mrjvs
Copy link
Contributor Author

mrjvs commented Jan 16, 2026

You picked all the weird ones with the custom head tags to do!

Yea, other than admin, this should all be the difficult stuff out of the way

@mrjvs mrjvs requested a review from ashquarky January 16, 2026 21:48
@mrjvs mrjvs merged commit da9edac into dev Jan 16, 2026
10 checks passed
@mrjvs mrjvs deleted the feat/even-more-jsx branch January 16, 2026 23:12
@mrjvs mrjvs mentioned this pull request Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants