Skip to content

fix: Actually log server errors on API #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrjvs merged 6 commits into from
Jul 12, 2025
Merged

fix: Actually log server errors on API #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f154131
locales(update): Updated French locale
DimitriPilot3 Jul 1, 2025
ab32aab
locales(update): Updated Hungarian locale
vargaviktor Jul 1, 2025
5e6d4fe
locales(update): Updated Indonesian locale
BoltOneUp Jul 1, 2025
1edc5c6
Merge pull request #142 from PretendoNetwork/weblate
ashquarky Jul 10, 2025
3cba1e5
fix(api): Actually log server errors
ashquarky Jul 12, 2025
ae6e6af
fix(api): Post id and body aren't actually required at input
ashquarky Jul 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/juxtaposition-ui/src/translations/fr.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"followers": "Abonnés",
"follow_user": "Suivre",
"following_user": "Suivi(e)",
"befriend": "Demander en ami",
"befriend": "Demander en ami(e)",
"pending": "En attente",
"unfriend": "Retirer des amis",
"no_friends": "Aucun ami",
Expand Down
2 changes: 1 addition & 1 deletion apps/juxtaposition-ui/src/translations/hu.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
"text_hint": "Koppints ide egy új bejegyzés létrehozásához."
},
"messages": {
"coming_soon": "Az Üzenetek még nincs kész. Nézz vissza később!"
"coming_soon": "Nincs üzenet"
},
"setup": {
"welcome": "Köszöntünk Juxtaposition-ben!",
Expand Down
2 changes: 1 addition & 1 deletion apps/juxtaposition-ui/src/translations/id.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,6 @@
"swearing": "Postingan tidak boleh mengandung bahasa eksplisit."
},
"messages": {
"coming_soon": "Pesan-Pesan belum siap sekarang. Segara periksa kembali!"
"coming_soon": "Tidak ada Pesanan"
}
}
7 changes: 5 additions & 2 deletions apps/miiverse-api/src/models/post.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,13 @@ import type { PostData, PostPainting, PostScreenshot, PostTopicTag } from '@/typ
* If you add default: or required:, please also update IPost and IPostInput!
*/
const PostSchema = new Schema<IPost, PostModel, IPostMethods>({
id: { type: String, required: true },
id: { type: String }, // generated in save hook
title_id: { type: String },
screen_name: { type: String, required: true },
body: { type: String, required: true },
body: {
type: String,
default: ''
},
app_data: { type: String },

painting: { type: String },
Expand Down
7 changes: 6 additions & 1 deletion apps/miiverse-api/src/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,12 @@ app.use((_request: express.Request, response: express.Response) => {

// non-404 error handler
logger.info('Creating non-404 status handler');
app.use((_error: unknown, _request: express.Request, response: express.Response, _next: express.NextFunction) => {
app.use((error: unknown, request: express.Request, response: express.Response, next: express.NextFunction) => {
if (response.headersSent) {
return next(error);
}

request.log.error(request, 'Request failed!');
return serverError(response, ApiErrorCode.UNKNOWN_ERROR);
});

Expand Down
2 changes: 2 additions & 0 deletions apps/miiverse-api/src/types/mongoose/post.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ export interface IPost {
// on input but not output
// We really need an ORM
type PostDefaultedFields =
'id' | // generated in save hook
'body' |
'is_autopost' |
'is_community_private_autopost' |
'is_spoiler' |
Expand Down