Conversation
If we're putting the method and such in the JSON object, it makes sense to keep the headers at that layer rather than pushing them up to gRPC. This lets the Express router access those headers in the usual way.
Easy mistake
This worked well for miiverse-api. It still just spits the stacktrace into the browser, but hey, at least it doesn't crash the server process
i'm not stupid i'm smart
some callsites to the old database method still exist, since the helpers on Post are used for things the backend doesn't have yet it's annoying to pass the whole Express request so just have a blob object for the things that the user is authenticated with
I went through a copy of the prod db and found lots of optional fields that aren't marked as such, old documents missing fields, etc. Introduces an IPostInput type that accounts for the mongoose schema doing defaults and fixes, while also allowing IPost to reflect the real db type. Groundwork for a proper DTO structure.
This provides a layer of abstraction between the actual database implementation and the on-the-wire types which will be useful when the database is changed soon
Mostly naming tweaks for clarity
Some paths use the login template to render errors (?) and this now requires a redirect URL. Provide one.
Place `.docker/mitmproxy-data/mitmproxy-ca-cert.pem` into `sdmc:/3ds/juxt-prod.pem`
fix: Use ParamPack type fix: typo in getUserFriendPIDs
Refactor "util" file to be TypeScript
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes: