Skip to content

Fix buttons on wishlist products#251

Merged
SharakPL merged 2 commits intoPrestaShop:devfrom
SharakPL:fix-buttons
Mar 5, 2024
Merged

Fix buttons on wishlist products#251
SharakPL merged 2 commits intoPrestaShop:devfrom
SharakPL:fix-buttons

Conversation

@SharakPL
Copy link
Contributor

@SharakPL SharakPL commented Mar 2, 2024

Questions Answers
Description? Product buttons in wishlists didn't get proper labels and styling, because of invalid checks. product.customizable is an INT, not a STRING.
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #{issue URL here}, Fixes #{another issue URL here}
Sponsor company Your company or customer's name goes here (if applicable).
How to test? 1. Add different products to your wishlist, including 1 out of stock and 1 customizable
2. Check your wishlist
3. Apply this PR and build assets
4. Check your wishlist again

before

obraz

after

obraz

@SharakPL SharakPL requested a review from a team March 2, 2024 14:43
@SharakPL SharakPL added this to the 3.0.2 milestone Mar 4, 2024
@AureRita AureRita self-assigned this Mar 5, 2024
@AureRita
Copy link

AureRita commented Mar 5, 2024

Hi @SharakPL

Thank you for your PR, currently when I test it, I didn't have the expected behavior, on hummingbird :

image

And on classic theme :

recording.127.webm

Tested on 8.1x and develop.

Have you some idea of why this doesn't works ?

Waiting for feedback

Copy link

@AureRita AureRita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SharakPL

after some review with you, I see that the PR seems to works as expected on

Hummingbird

recording.129.webm

and on classic theme
image

so its QA ✔️

Thank you !

@AureRita AureRita removed their assignment Mar 5, 2024
@SharakPL SharakPL merged commit 46273b6 into PrestaShop:dev Mar 5, 2024
@SharakPL
Copy link
Contributor Author

SharakPL commented Mar 5, 2024

Thanks @AureRita

@SharakPL SharakPL deleted the fix-buttons branch March 5, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants