Skip to content

Fix exception message when entering invalid characters#179

Merged
jolelievre merged 2 commits intodevfrom
unknown repository
Jul 13, 2022
Merged

Fix exception message when entering invalid characters#179
jolelievre merged 2 commits intodevfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Jun 25, 2022

Questions Answers
Description? An exception is displayed when creating a list with an invalid name
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Fixes 28835
How to test? Try to enter test = test when you create a wish list
Possible impacts?
Sponsor company @friends-of-presta

@ghost ghost changed the title Fix exception message Fix exception message when entering invalid characters Jun 25, 2022
Copy link

@sLorenzini sLorenzini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello @okom3pom,

Thank you for this PR.
Tested on develop, 178x & 80x versions, PHP 7.3

Error message is well displayed instead of 500 error ✅

  • develop
developwishlist.mp4
  • 178x
178wishlist.mp4
  • 80x
80xwishlist.mp4

QA approved ✅

Thanks

@sLorenzini sLorenzini self-assigned this Jul 13, 2022
@jolelievre jolelievre merged commit f963520 into PrestaShop:dev Jul 13, 2022
@jolelievre
Copy link
Contributor

Thanks @okom3pom and @sLorenzini

@NeOMakinG NeOMakinG added this to the 2.1.2 milestone Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FO - Wishlist - An exception is displayed when we create a list with invalid

6 participants