Fix issue #628 with '.A' stuff on csr_matrix #631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qtuantruong
requested changes
Jun 28, 2024
qtuantruong
approved these changes
Jul 5, 2024
5 tasks
qtuantruong
added a commit
to qtuantruong/cornac
that referenced
this pull request
Oct 25, 2025
* Fix issue PreferredAI#628 with '.A' stuff on csr_matrix * Modifying requirements.txt for numpy and another .A --------- Co-authored-by: tqtg <[email protected]>
qtuantruong
added a commit
to qtuantruong/cornac
that referenced
this pull request
Oct 25, 2025
* Fix issue PreferredAI#628 with '.A' stuff on csr_matrix * Modifying requirements.txt for numpy and another .A --------- Co-authored-by: tqtg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the issue concerning '.A' alias deprecated with latest Scipy version (from 1.11).
Change '.A' to '.toarray()' in scoring functions in knn models.
Also fixing upper bound on numpy version until compatibility is done in requirements
Related Issues
Fix #629
Checklist:
README.md(if you are adding a new model).examples/README.md(if you are adding a new example).datasets/README.md(if you are adding a new dataset).