Fix EFM._build_matrices() method #616
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The two methods
knows_userandknows_itemcheck whetheruid(oriid) is smaller thanself.num_users(orself.num_items), which doesn't exist becausefit()was never executed.This commit tries to fix an error in
recommender-systemstutorial notebook 7, whereEFM.train_setis assigned and_build_matrices()is executed beforefit():