16658 work pool queue update events#19688
Conversation
Add event emission for work pool and work queue field updates beyond status changes. Events are created when user-updatable fields change: - Work pools: description, base_job_template, concurrency_limit, storage_configuration - Work queues: name, description, concurrency_limit, priority
Emit events when work pools and work queues are updated Previously, events were only created when status changed. Now we also emit events when other fields like description, concurrency_limit, or priority are updated. This enables automations based on configuration changes. Events include the old and new values in the payload.
CodSpeed Performance ReportMerging #19688 will not alter performanceComparing Summary
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
desertaxle
left a comment
desertaxle
left a comment
There was a problem hiding this comment.
Thanks for the PR @F4RAN! This looks solid; just a couple of requested changes from me!
Co-authored-by: Alex Streed <desertaxle@users.noreply.github.com>
Co-authored-by: Alex Streed <desertaxle@users.noreply.github.com>
Co-authored-by: Alex Streed <desertaxle@users.noreply.github.com>
Co-authored-by: Alex Streed <desertaxle@users.noreply.github.com>
Co-authored-by: Alex Streed <desertaxle@users.noreply.github.com>
|
@desertaxle Thanks for the feedback! I've made the requested changes:
Happy to make any additional changes if needed! |
desertaxle
left a comment
desertaxle
left a comment
There was a problem hiding this comment.
This LGTM! @zzstoatzz do you want to give this one a look too?
zzstoatzz
left a comment
zzstoatzz
left a comment
There was a problem hiding this comment.
sorry for delay! lgtm
3 participants
This PR adds event emission for work pool and work queue field updates beyond status changes. Previously, events were only created when the status field changed. Now events are also emitted when user-updatable fields like
description,concurrency_limit,priority, etc. are updated.This enables automations based on configuration changes, such as notifying on Slack when a work pool's concurrency limit is updated or scaling resources when a work queue's priority changes.
Checklist
<link to issue>"mint.json.