Skip to content

fix: RRuleSchedule test flakiness from DST-dependent date #19305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2025
Merged

fix: RRuleSchedule test flakiness from DST-dependent date #19305

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions tests/server/schemas/test_schedules.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
IntervalSchedule,
RRuleSchedule,
)
from prefect.types._datetime import now, parse_datetime, start_of_day
from prefect.types._datetime import now, parse_datetime

dt = datetime(2020, 1, 1, tzinfo=ZoneInfo("UTC"))
RRDaily = "FREQ=DAILY"
Expand Down Expand Up @@ -869,12 +869,17 @@ async def test_create_with_timezone(self):
)
assert s.timezone == "America/New_York"

dates = await s.get_dates(5)
# Use a fixed start date to avoid DST-related flakiness
start = datetime(2025, 1, 15, tzinfo=ZoneInfo("UTC"))
dates = await s.get_dates(5, start=start)
assert dates[0].tzinfo.key == "America/New_York"
assert dates == [
start_of_day(now("America/New_York")) + timedelta(days=i + 1)

expected = [
datetime(2025, 1, 15, 0, 0, 0, tzinfo=ZoneInfo("America/New_York"))
+ timedelta(days=i)
for i in range(5)
]
assert dates == expected


class TestRRuleSchedule:
Expand Down