Fix forward reference resolution in ValidatedFunction
#19289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #19288 This PR fixes an issue where Flow.validate_parameters() fails when using Pydantic models as parameters with `from __future__ import annotations`. The problem occurred because the dynamically created validation model didn't have access to the original function's namespace to resolve forward references. The fix adds model_rebuild() with the function's global namespace, allowing proper resolution of forward references to Pydantic models. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
CodSpeed Performance ReportMerging #19289 will not alter performanceComparing Summary
|
This commit adds a performance optimization to avoid calling model_rebuild() when there are no forward references in the function signature. The optimization: - Detects string annotations during field building - Only calls model_rebuild() if forward references are found - Avoids unnecessary overhead for functions without forward refs 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Improves test coverage by using unittest.mock to verify that: - model_rebuild() is NOT called when there are no forward references - model_rebuild() IS called with correct namespace when forward refs exist This ensures the performance optimization is actually working as intended. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
desertaxle
changed the title
ValidatedFunction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19288
This PR fixes an issue where
Flow.validate_parameters()fails when using Pydantic models as parameters withfrom __future__ import annotations.Details
Problem
After #19119 was merged, users reported that
Flow.validate_parameters()raised aPydanticUserErrorwhen:from __future__ import annotations(which makes type hints strings/forward references)The error was:
Root Cause
In
validated_func.py, the_create_model()method dynamically creates a Pydantic model to validate function parameters. However, this dynamically created model didn't have access to the original function's namespace to resolve forward references.Solution
Added
self.model.model_rebuild(_types_namespace=self.raw_function.__globals__)at the end of_create_model(). This provides the model with the original function's global namespace to properly resolve forward references to Pydantic models and other types.🤖 Generated with Claude Code