Skip to content

Conversation

@zzstoatzz
Copy link
Collaborator

closes #19259

this PR updates the typer minimum from >=0.12.0 to >=0.16.0 to prevent dependency solvers from picking incompatible combinations with click 8.2+.

details

background

while fixing the conda-forge feedstock for prefect 3.4.24, we discovered that the conda solver was picking typer 0.12.5 (the minimum allowed by our constraint), which fails with click 8.3.0:

TypeError: Secondary flag is not valid for non-boolean flag.

our Docker builds work fine because uv.lock pins to exactly typer 0.16.0.

testing

tested with fresh environments and prefect 3.4.24:

  • typer 0.12.5 + click 8.3.0: ✗ fails with TypeError
  • typer 0.15.0 + click 8.3.0: ✗ fails (different error)
  • typer 0.16.0 + click 8.3.0: ✓ works

changes

  • updated typer constraint from >=0.12.0,!=0.12.2,<0.20.0 to >=0.16.0,<0.20.0
  • removed !=0.12.2 exclusion (now redundant)
  • updated uv.lock

related conda-forge feedstock PR: conda-forge/prefect-feedstock#410

Prefect 3.4.24 requires typer>=0.16.0 to work with click 8.2+.

The current constraint (typer>=0.12.0) allows dependency solvers to pick
typer 0.12.5, which fails with click 8.3.0:
  TypeError: Secondary flag is not valid for non-boolean flag.

This was discovered while fixing the conda-forge feedstock, where the
conda solver was picking typer 0.12.5. Our Docker builds work because
uv.lock pins to exactly 0.16.0.

Tested combinations:
- typer 0.12.5 + click 8.3.0: fails
- typer 0.15.0 + click 8.3.0: fails (different error)
- typer 0.16.0 + click 8.3.0: works

Removed !=0.12.2 exclusion as it's now redundant.

Related to #19259
@github-actions github-actions bot added enhancement An improvement of an existing feature labels Oct 23, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 23, 2025

CodSpeed Performance Report

Merging #19269 will not alter performance

Comparing update-typer-minimum (2b97f5c) with main (8a37e7b)

Summary

✅ 2 untouched

@zzstoatzz zzstoatzz added development Tech debt, refactors, CI, tests, and other related work. and removed enhancement An improvement of an existing feature labels Oct 23, 2025
@zzstoatzz zzstoatzz merged commit 1e20583 into main Oct 23, 2025
65 checks passed
@zzstoatzz zzstoatzz deleted the update-typer-minimum branch October 23, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development Tech debt, refactors, CI, tests, and other related work.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Click 8.2+ support

3 participants