use settings for some defaults, avoid warnings #682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzstoatzz
commented
Dec 14, 2023
| data: dict[str, Any] = {} | ||
| data[field_name] = json.loads(tool_arguments[0]) | ||
| return response_model.model_validate_json(json.dumps(data)) | ||
| else: |
Collaborator
Author
There was a problem hiding this comment.
this was unreachable
zzstoatzz
commented
Dec 14, 2023
|
|
||
| return create_model( | ||
| model_name, | ||
| __doc__=model_description, |
Collaborator
Author
There was a problem hiding this comment.
model_description was unused
zzstoatzz
commented
Dec 14, 2023
| client: Optional[Client] = None | ||
| aclient: Optional[AsyncClient] = None | ||
| temperature: Optional[float] = None | ||
| temperature: Optional[float] = marvin.settings.openai.chat.completions.temperature |
Collaborator
Author
There was a problem hiding this comment.
was getting 400s without these
zzstoatzz
commented
Dec 14, 2023
|
|
||
| class AIFunctionKwargsDefaults(BaseModel): | ||
| model_config = ConfigDict(arbitrary_types_allowed=True) | ||
| model_config = ConfigDict(arbitrary_types_allowed=True, protected_namespaces=()) |
Collaborator
Author
There was a problem hiding this comment.
avoid warning about infringing on sacred model_* namespace
aaazzam
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a couple tweaks from playing with the
service-layerbranchthis is looking cool!
does
marvin._mappings.typesnullify what we have inmarvin.serializersfor the most part?